Bug 101049 - Fix build warning in PluginView.cpp on release build
Summary: Fix build warning in PluginView.cpp on release build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: KyungTae Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-02 06:46 PDT by KyungTae Kim
Modified: 2012-11-02 23:26 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.67 KB, patch)
2012-11-02 06:49 PDT, KyungTae Kim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description KyungTae Kim 2012-11-02 06:46:46 PDT 
Source/WebCore/plugins/PluginView.cpp:1475:9: warning: unused parameter 'protocol' [-Wunused-parameter]
Source/WebCore/plugins/PluginView.cpp:1475:9: warning: unused parameter 'host' [-Wunused-parameter]
Source/WebCore/plugins/PluginView.cpp:1475:9: warning: unused parameter 'port' [-Wunused-parameter]

The protocol, host, port parameters for PluginView::getAuthenticationInfo are not used when LOG_DISABLED
Comment 1 KyungTae Kim 2012-11-02 06:49:20 PDT 
Created attachment 172050 [details]
Patch
Comment 2 Kentaro Hara 2012-11-02 09:16:29 PDT 
Comment on attachment 172050 [details]
Patch

Looks OK
Comment 3 WebKit Review Bot 2012-11-02 23:26:34 PDT 
Comment on attachment 172050 [details]
Patch

Clearing flags on attachment: 172050

Committed r133390: <http://trac.webkit.org/changeset/133390>
Comment 4 WebKit Review Bot 2012-11-02 23:26:39 PDT 
All reviewed patches have been landed.  Closing bug.