RESOLVED FIXED101046
Imrpove scoring in touch adjustment to address bias towards smaller targets. 
https://bugs.webkit.org/show_bug.cgi?id=101046
Summary Imrpove scoring in touch adjustment to address bias towards smaller targets.
Kevin Ellis
Reported 2012-11-02 06:09:03 PDT
Imrpove scoring in touch adjustment to address bias towards smaller targets.
Attachments
Patch (4.89 KB, patch)
2012-11-02 06:16 PDT, Kevin Ellis 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kevin Ellis
Comment 1 2012-11-02 06:16:03 PDT
Created attachment 172047 [details] Patch
Kevin Ellis
Comment 2 2012-11-02 06:26:55 PDT
The patch addresses problems with touch adjustment at the boundary of a flash plugin. Previously, we normalized the overlap score with respect to the size of the candidate element. The flash plugin being typically very large compared to the touch area resulted in a very poor overlap score even if the touch is entirely contained within the plugin boundary.
Kevin Ellis
Comment 3 2012-11-02 06:32:44 PDT
Comment on attachment 172047 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172047&action=review > LayoutTests/touchadjustment/rotated-node.html:75 > + testTouchPoint(touchPoint(71, 0, 20), e.container); Original position clipped boundary due to rounding. Bumping the offset slightly addresses the overlap, while still ensuring that the bounds overlaps the rectilinear bounds of the target. Overlap of the rectilinear bounds is required to properly test that the candidate is rejected during touch adjustment.
WebKit Review Bot
Comment 4 2012-11-02 10:19:33 PDT
Comment on attachment 172047 [details] Patch Clearing flags on attachment: 172047 Committed r133312: <http://trac.webkit.org/changeset/133312>
WebKit Review Bot
Comment 5 2012-11-02 10:19:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.