Bug 101046 - Imrpove scoring in touch adjustment to address bias towards smaller targets.
Summary: Imrpove scoring in touch adjustment to address bias towards smaller targets.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kevin Ellis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-02 06:09 PDT by Kevin Ellis
Modified: 2012-11-02 10:19 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.89 KB, patch)
2012-11-02 06:16 PDT, Kevin Ellis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Ellis 2012-11-02 06:09:03 PDT
Imrpove scoring in touch adjustment to address bias towards smaller targets.
Comment 1 Kevin Ellis 2012-11-02 06:16:03 PDT
Created attachment 172047 [details]
Patch
Comment 2 Kevin Ellis 2012-11-02 06:26:55 PDT
The patch addresses problems with touch adjustment at the boundary of a flash plugin.  Previously, we normalized the overlap score with respect to the size of the candidate element.  The flash plugin being typically very large compared to the touch area resulted in a very poor overlap score even if the touch is entirely contained within the plugin boundary.
Comment 3 Kevin Ellis 2012-11-02 06:32:44 PDT
Comment on attachment 172047 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172047&action=review

> LayoutTests/touchadjustment/rotated-node.html:75
> +        testTouchPoint(touchPoint(71, 0, 20), e.container);

Original position clipped boundary due to rounding.  Bumping the offset slightly addresses the overlap, while still ensuring that the bounds overlaps the rectilinear bounds of the target.  Overlap of the rectilinear bounds is required to properly test that the candidate is rejected during touch adjustment.
Comment 4 WebKit Review Bot 2012-11-02 10:19:33 PDT
Comment on attachment 172047 [details]
Patch

Clearing flags on attachment: 172047

Committed r133312: <http://trac.webkit.org/changeset/133312>
Comment 5 WebKit Review Bot 2012-11-02 10:19:36 PDT
All reviewed patches have been landed.  Closing bug.