Bug 101029 - Fix build warning [-Wswitch]
Summary: Fix build warning [-Wswitch]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jinwoo Song
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-02 02:12 PDT by Jinwoo Song
Modified: 2012-11-02 10:58 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.54 KB, patch)
2012-11-02 02:27 PDT, Jinwoo Song 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jinwoo Song 2012-11-02 02:12:28 PDT 
/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebCore/css/StyleSheetContents.cpp:421:16: warning: enumeration value ‘Viewport’ not handled in switch [-Wswitch]
Comment 1 Jinwoo Song 2012-11-02 02:27:39 PDT 
Created attachment 172012 [details]
Patch
Comment 2 Thiago Marcos P. Santos 2012-11-02 03:04:45 PDT 
Comment on attachment 172012 [details]
Patch

LGTM.
Comment 3 Alexey Proskuryakov 2012-11-02 10:47:16 PDT 
Comment on attachment 172012 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172012&action=review

> Source/WebCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

You should have marked the patch for review, not just commit queue. Commit queue won't land a patch with this line unless it's marked r+.

I'll mark it r+, because it seems clear that this was your intention.
Comment 4 WebKit Review Bot 2012-11-02 10:58:06 PDT 
Comment on attachment 172012 [details]
Patch

Clearing flags on attachment: 172012

Committed r133316: <http://trac.webkit.org/changeset/133316>
Comment 5 WebKit Review Bot 2012-11-02 10:58:09 PDT 
All reviewed patches have been landed.  Closing bug.