WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
101017
Web Inspector: Support user timing mark and measure in Timeline panel
https://bugs.webkit.org/show_bug.cgi?id=101017
Summary
Web Inspector: Support user timing mark and measure in Timeline panel
pdeng6
Reported
2012-11-01 23:04:39 PDT
performance.mark and measure will be widely supported as W3C User Timing[1] Spec. Furthermore, performance.measure can provide a start to end timing, according to this, user can choose region they care in overview pane easily if we draw measure on timeline. It should be a supplement of console.timeStamp & console.markTimeline. Reasonable? :) [1]
http://www.w3.org/TR/2012/CR-user-timing-20120726/
Attachments
Add attachment
proposed patch, testcase, etc.
Pavel Feldman
Comment 1
2012-11-01 23:07:33 PDT
Could you explain why we need another method of marking the timeline? Also, note that console.time and timeEnd allows selecting a region on the timeline today.
Pavel Feldman
Comment 2
2012-11-01 23:15:48 PDT
(In reply to
comment #1
)
> Could you explain why we need another method of marking the timeline? Also, note that console.time and timeEnd allows selecting a region on the timeline today.
I.e. I think they make sense wherever rest of the performance API is visualized. Otherwise it will be hard for the developer to find correlation between these signals and the other ones originating from the inspector instrumentation. Like timeline has been using wall clock until recently. Alternatively, we could deprecate console's time methods and make sure performance API is aligned with the inspector data. That might require re-implementing some of performance guts on top of inspector instrumentation. Tony, James, what do you think, could we try aligning them?
pdeng6
Comment 3
2012-11-01 23:34:07 PDT
(In reply to
comment #1
)
> Could you explain why we need another method of marking the timeline? Also, note that console.time and timeEnd allows selecting a region on the timeline today.
Reason is people who use User Timing can also mark the timeline, and it’s not conflict with console.timeStamp I think.
pdeng6
Comment 4
2012-11-01 23:38:26 PDT
(In reply to
comment #1
)
> Could you explain why we need another method of marking the timeline? Also, note that console.time and timeEnd allows selecting a region on the timeline today.
In addition, I tried console.time & console.timeEnd in chromium trunk today, only found timeEnd, and it is without mark names and not available via “Ctrl+F”, I will file this in another bug entry if it's agreed. :)
pdeng6
Comment 5
2012-11-12 19:20:55 PST
(In reply to
comment #2
)
> (In reply to
comment #1
) > > Could you explain why we need another method of marking the timeline? Also, note that console.time and timeEnd allows selecting a region on the timeline today. > > I.e. I think they make sense wherever rest of the performance API is visualized. Otherwise it will be hard for the developer to find correlation between these signals and the other ones originating from the inspector instrumentation. Like timeline has been using wall clock until recently.
What if wall clock adjusted during instrumentation?
> > Alternatively, we could deprecate console's time methods and make sure performance API is aligned with the inspector data. That might require re-implementing some of performance guts on top of inspector instrumentation. Tony, James, what do you think, could we try aligning them?
Encourage developer to use user timing to mark timeline as standard is reasonable, as standard. I guess re-implementing performance on top of inspector instrumentation is not a must if timing mechanism is aligned.
Brian Burg
Comment 6
2014-12-12 13:41:18 PST
Closing as invalid, as this bug pertains to the old inspector UI and/or its tests. Please file a new bug (
https://www.webkit.org/new-inspector-bug
) if the bug/feature/issue is still relevant to WebKit trunk.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug