RESOLVED FIXED 101014
visitedHashLink() converts 8 bit URLs and attributes to 16 bits. 
https://bugs.webkit.org/show_bug.cgi?id=101014
Summary visitedHashLink() converts 8 bit URLs and attributes to 16 bits.
Michael Saboff
Reported 2012-11-01 22:08:15 PDT
visitedHashLink() calls characters() on both the base URL and attribute do compute the hash. This code should check the bitness of the strings and use characters8() or characters16() as appropriate.
Attachments
Patch (8.76 KB, patch)
2012-11-01 22:16 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2012-11-01 22:16:24 PDT
Created attachment 171985 [details] Patch
Geoffrey Garen
Comment 2 2012-11-02 12:52:42 PDT
Comment on attachment 171985 [details] Patch r=me
WebKit Review Bot
Comment 3 2012-11-02 13:22:22 PDT
Comment on attachment 171985 [details] Patch Clearing flags on attachment: 171985 Committed r133334: <http://trac.webkit.org/changeset/133334>
WebKit Review Bot
Comment 4 2012-11-02 13:22:25 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 5 2012-11-02 16:08:40 PDT
Comment on attachment 171985 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171985&action=review > Source/WebCore/platform/LinkHash.cpp:179 > +template <typename CharacterType> > +static inline bool matchLetter(CharacterType c, char lowercaseLetter) > { > return (c | 0x20) == lowercaseLetter; > } This is a duplicate of the isASCIIAlphaCaselessEqual function from ASCIICType.h; we should use that instead of duplicating it.
Note You need to log in before you can comment on or make changes to this bug.