Bug 101012 - JSC: llint workaround for a toolchain issue
Summary: JSC: llint workaround for a toolchain issue
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-11-01 20:07 PDT by Mark Lam
Modified: 2012-11-01 21:43 PDT (History)
4 users (show)

See Also:


Attachments
Fix. (1.57 KB, patch)
2012-11-01 20:13 PDT, Mark Lam
msaboff: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2012-11-01 20:07:37 PDT
Some toolchain doesn't like the way the llint is using a global label.  Will work around it using a local label.
Comment 1 Mark Lam 2012-11-01 20:13:52 PDT
Created attachment 171980 [details]
Fix.
Comment 2 Mark Lam 2012-11-01 20:15:17 PDT
<rdar://problem/12618934>
Comment 3 Michael Saboff 2012-11-01 21:32:12 PDT
Comment on attachment 171980 [details]
Fix.

View in context: https://bugs.webkit.org/attachment.cgi?id=171980&action=review

r+

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:750
> +.llint_op_resolve_start:

Would it be better to call this .llint_op_resolve_local: instead?
Comment 4 Mark Lam 2012-11-01 21:43:50 PDT
I've changed the label to end with "_local" instead.

Landed in r133265: <http://trac.webkit.org/changeset/133265>.