WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
101008
https://bugs.webkit.org/show_bug.cgi?id=99647
broke the Windows build
https://bugs.webkit.org/show_bug.cgi?id=101008
Summary
https://bugs.webkit.org/show_bug.cgi?id=99647 broke the Windows build
Roger Fong
Reported
2012-11-01 19:35:41 PDT
https://bugs.webkit.org/show_bug.cgi?id=99647
broke the Windows build. Submitting a patch for build fix.
Attachments
patch
(1.72 KB, patch)
2012-11-01 19:41 PDT
,
Roger Fong
fischman
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Roger Fong
Comment 1
2012-11-01 19:41:26 PDT
Created
attachment 171977
[details]
patch
Ami Fischman
Comment 2
2012-11-01 19:44:28 PDT
Comment on
attachment 171977
[details]
patch LGTM (but I can't r+ since I'm not a WK reviewer).
Roger Fong
Comment 3
2012-11-01 19:54:28 PDT
Committed:
http://trac.webkit.org/changeset/133262
Darin Adler
Comment 4
2012-11-02 15:56:13 PDT
Comment on
attachment 171977
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=171977&action=review
> Source/WebCore/html/HTMLMediaElement.cpp:3712 > +void HTMLMediaElement::clearMediaPlayer(signed flags)
We call this type int, not signed, in WebKit project source.
Roger Fong
Comment 5
2012-11-02 22:37:37 PDT
(In reply to
comment #4
)
> (From update of
attachment 171977
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=171977&action=review
> > > Source/WebCore/html/HTMLMediaElement.cpp:3712 > > +void HTMLMediaElement::clearMediaPlayer(signed flags) > > We call this type int, not signed, in WebKit project source.
oops, will fix
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug