Bug 101004 – quoteCSSString() always creates a 16 bit string

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Michael Saboff]

quoteCSSString() in CSSParser.cpp should create an 8 bit string for most case.

[Michael Saboff]

Created attachment 171967 [details]
Patch

[Darin Adler]

Comment on attachment 171967 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171967&action=review

> Source/WebCore/css/CSSParser.cpp:10640
> +    if (string.length() >= (std::numeric_limits<unsigned>::max() / 3) - 2)

Not new code, but seems to me there are extra parentheses here. Also seems strange to use >= here instead of just >.

> Source/WebCore/css/CSSParser.cpp:10641
> +        return "";

Should probably use emptyString() here since it makes more efficient code.

[WebKit Review Bot]

Comment on attachment 171967 [details]
Patch

Attachment 171967 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14670963

New failing tests:
svg/W3C-SVG-1.1/animate-elem-78-t.svg
svg/W3C-SVG-1.1/animate-elem-52-t.svg

[Michael Saboff]

Created attachment 172157 [details]
Patch with suggested changes and speculative chromium fix

[Darin Adler]

Comment on attachment 172157 [details]
Patch with suggested changes and speculative chromium fix

I wonder if it would be better to change this to use StringBuilder instead of StringBuffer at some point.

[WebKit Review Bot]

Comment on attachment 172157 [details]
Patch with suggested changes and speculative chromium fix

Clearing flags on attachment: 172157

Committed r133625: <http://trac.webkit.org/changeset/133625>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.