RESOLVED FIXED 100998
webkit-patch analyze-baselines output is weak 
https://bugs.webkit.org/show_bug.cgi?id=100998
Summary webkit-patch analyze-baselines output is weak
Dirk Pranke
Reported 2012-11-01 16:23:22 PDT
webkit-patch analyze-baselines output is weak
Attachments
Patch (10.30 KB, patch)
2012-11-01 16:25 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
fix tests and modify output when optimize fails (12.59 KB, patch)
2012-11-01 18:09 PDT, Dirk Pranke 		ojan: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2012-11-01 16:25:16 PDT
Created attachment 171951 [details] Patch
Dirk Pranke
Comment 2 2012-11-01 18:09:56 PDT
Created attachment 171963 [details] fix tests and modify output when optimize fails
Ojan Vafai
Comment 3 2012-11-01 18:26:14 PDT
Comment on attachment 171963 [details] fix tests and modify output when optimize fails View in context: https://bugs.webkit.org/attachment.cgi?id=171963&action=review > Tools/Scripts/webkitpy/tool/commands/rebaseline.py:225 > + optparse.make_option('--missing', action='store_true', default=False, help='show missing baselines as well'), Why not always do this?
Dirk Pranke
Comment 4 2012-11-01 21:02:32 PDT
(In reply to comment #3) > (From update of attachment 171963 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=171963&action=review > > > Tools/Scripts/webkitpy/tool/commands/rebaseline.py:225 > > + optparse.make_option('--missing', action='store_true', default=False, help='show missing baselines as well'), > > Why not always do this? Because most of the time we're missing baselines for .wav and usually .png files, and printing "missing" gets awfully verbose.
Dirk Pranke
Comment 5 2012-11-02 12:02:48 PDT
Committed r133328: <http://trac.webkit.org/changeset/133328>
Note You need to log in before you can comment on or make changes to this bug.