Bug 100998 - webkit-patch analyze-baselines output is weak
Summary: webkit-patch analyze-baselines output is weak
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-01 16:23 PDT by Dirk Pranke
Modified: 2012-11-02 12:02 PDT (History)
3 users (show)

See Also:

Attachments
Patch (10.30 KB, patch)
2012-11-01 16:25 PDT, Dirk Pranke 		no flags Details | Formatted Diff | Diff
fix tests and modify output when optimize fails (12.59 KB, patch)
2012-11-01 18:09 PDT, Dirk Pranke 		ojan: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-11-01 16:23:22 PDT 
webkit-patch analyze-baselines output is weak
Comment 1 Dirk Pranke 2012-11-01 16:25:16 PDT 
Created attachment 171951 [details]
Patch
Comment 2 Dirk Pranke 2012-11-01 18:09:56 PDT 
Created attachment 171963 [details]
fix tests and modify output when optimize fails
Comment 3 Ojan Vafai 2012-11-01 18:26:14 PDT 
Comment on attachment 171963 [details]
fix tests and modify output when optimize fails

View in context: https://bugs.webkit.org/attachment.cgi?id=171963&action=review

> Tools/Scripts/webkitpy/tool/commands/rebaseline.py:225
> +            optparse.make_option('--missing', action='store_true', default=False, help='show missing baselines as well'),

Why not always do this?
Comment 4 Dirk Pranke 2012-11-01 21:02:32 PDT 
(In reply to comment #3)
> (From update of attachment 171963 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=171963&action=review
> 
> > Tools/Scripts/webkitpy/tool/commands/rebaseline.py:225
> > +            optparse.make_option('--missing', action='store_true', default=False, help='show missing baselines as well'),
> 
> Why not always do this?

Because most of the time we're missing baselines for .wav and usually .png files, and printing "missing" gets awfully verbose.
Comment 5 Dirk Pranke 2012-11-02 12:02:48 PDT 
Committed r133328: <http://trac.webkit.org/changeset/133328>