WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
100994
Ensure that AudioNode deletion is synchronized with a stable state of the rendering graph
https://bugs.webkit.org/show_bug.cgi?id=100994
Summary
Ensure that AudioNode deletion is synchronized with a stable state of the ren...
Chris Rogers
Reported
2012-11-01 15:19:14 PDT
Ensure that AudioNode deletion is synchronized with a stable state of the rendering graph
Attachments
Patch
(3.88 KB, patch)
2012-11-01 15:30 PDT
,
Chris Rogers
kbr
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Rogers
Comment 1
2012-11-01 15:30:44 PDT
Created
attachment 171944
[details]
Patch
Kenneth Russell
Comment 2
2012-11-01 15:49:49 PDT
Comment on
attachment 171944
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=171944&action=review
This fix looks OK but there's a comment that needs to be updated. Please do that before landing. r=me
> Source/WebCore/Modules/webaudio/AudioContext.cpp:786 > + m_nodesToDelete.append(m_nodesMarkedForDeletion[i]);
There is now a stale comment about m_nodesToDelete in AudioContext::deleteMarkedNodes() that needs to be adjusted.
Chris Rogers
Comment 3
2012-11-01 16:24:13 PDT
Committed
r133239
: <
http://trac.webkit.org/changeset/133239
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug