NEW 100991
Refactor ReplayPerfTest and PageLoadingPerfTest 
https://bugs.webkit.org/show_bug.cgi?id=100991
Summary Refactor ReplayPerfTest and PageLoadingPerfTest
Zoltan Horvath
Reported 2012-11-01 14:49:17 PDT
Since we removed the PageLoadingPerfTest conception we don't need that class, but ReplayPerfTest uses it, so it's time to do some cleanup.
Attachments
Work in progress (7.00 KB, patch)
2012-11-07 01:09 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Demonstrates interesting cache-dependent behavior (26.14 KB, text/html)
2012-11-07 01:12 PST, Ryosuke Niwa 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2012-11-01 15:16:24 PDT
I think we can change ReplayPerfTest to use the same iframe approach.
Zoltan Horvath
Comment 2 2012-11-01 16:05:22 PDT
(In reply to comment #1) > I think we can change ReplayPerfTest to use the same iframe approach. Good point and it makes sense, since it would be really interesting to measure the memory usage after a page loads. I'll do it with this in mind.
Ryosuke Niwa
Comment 3 2012-11-07 01:08:41 PST
I think we can make ReplayPerfTest inherit from PerfTest and use the same iframe approach.
Ryosuke Niwa
Comment 4 2012-11-07 01:09:52 PST
Created attachment 172732 [details] Work in progress Here's a snippet of code that turns replay tests into an iframe-based tests.
Ryosuke Niwa
Comment 5 2012-11-07 01:12:38 PST
Created attachment 172733 [details] Demonstrates interesting cache-dependent behavior For some reason, immediately changing iframe's src makes subsequent page loads really fast. Delaying it with 50ms or so will make the results more uniform across iterations. I'm not sure whether this behavior is caused by WebCore or web-page-replay.
Note You need to log in before you can comment on or make changes to this bug.