RESOLVED FIXED 100988
[chromium] Try to find ninja if it's not in the path already 
https://bugs.webkit.org/show_bug.cgi?id=100988
Summary [chromium] Try to find ninja if it's not in the path already
Nico Weber
Reported 2012-11-01 14:30:21 PDT
[chromium] Try to find ninja if it's not in the path already
Attachments
Patch (1.51 KB, patch)
2012-11-01 14:30 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nico Weber
Comment 1 2012-11-01 14:30:54 PDT
Created attachment 171931 [details] Patch
Ryosuke Niwa
Comment 2 2012-11-01 14:34:22 PDT
Comment on attachment 171931 [details] Patch Oosp, we still get an error: Source/WebKit/chromium/depot_tools/ninja: line 12: exec: ninja-mac: not found
Nico Weber
Comment 3 2012-11-01 14:40:13 PDT
that's not the same error, it's a different error. it now finds the ninja shell script in depot_tools, but that too assumes that depot_tools is in the path when it dispatches to ninja-mac. That will be fixed by https://codereview.chromium.org/11366044 Can you restore r+ please?
Ryosuke Niwa
Comment 4 2012-11-01 14:40:36 PDT
I think we can put depot_tools in $PATH when we install one so that subprocesses will use that.
Ryosuke Niwa
Comment 5 2012-11-01 14:40:46 PDT
Comment on attachment 171931 [details] Patch ok
WebKit Review Bot
Comment 6 2012-11-01 17:59:28 PDT
Comment on attachment 171931 [details] Patch Clearing flags on attachment: 171931 Committed r133246: <http://trac.webkit.org/changeset/133246>
WebKit Review Bot
Comment 7 2012-11-01 17:59:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.