Bug 100988 - [chromium] Try to find ninja if it's not in the path already
Summary: [chromium] Try to find ninja if it's not in the path already
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nico Weber
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-01 14:30 PDT by Nico Weber
Modified: 2012-11-01 17:59 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.51 KB, patch)
2012-11-01 14:30 PDT, Nico Weber 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Weber 2012-11-01 14:30:21 PDT 
[chromium] Try to find ninja if it's not in the path already
Comment 1 Nico Weber 2012-11-01 14:30:54 PDT 
Created attachment 171931 [details]
Patch
Comment 2 Ryosuke Niwa 2012-11-01 14:34:22 PDT 
Comment on attachment 171931 [details]
Patch

Oosp, we still get an error:
Source/WebKit/chromium/depot_tools/ninja: line 12: exec: ninja-mac: not found
Comment 3 Nico Weber 2012-11-01 14:40:13 PDT 
that's not the same error, it's a different error. it now finds the ninja shell script in depot_tools, but that too assumes that depot_tools is in the path when it dispatches to ninja-mac. That will be fixed by https://codereview.chromium.org/11366044

Can you restore r+ please?
Comment 4 Ryosuke Niwa 2012-11-01 14:40:36 PDT 
I think we can put depot_tools in $PATH when we install one so that subprocesses will use that.
Comment 5 Ryosuke Niwa 2012-11-01 14:40:46 PDT 
Comment on attachment 171931 [details]
Patch

ok
Comment 6 WebKit Review Bot 2012-11-01 17:59:28 PDT 
Comment on attachment 171931 [details]
Patch

Clearing flags on attachment: 171931

Committed r133246: <http://trac.webkit.org/changeset/133246>
Comment 7 WebKit Review Bot 2012-11-01 17:59:32 PDT 
All reviewed patches have been landed.  Closing bug.