Bug 100983 – [EFL][WK2][AC] Wrong translation of mouse events

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Yael]

Translation of mouse events does not take the url bar into account correctly.
To reproduce this error:
1. load the page www.aldaily.com
2. make the viewport narrower
3. scroll down
4. use the mouse to select text
You will observe that the text selection is bellow where the mouse is.
If you extend the width of the viewport until the scale factor becomes 1, and then the selection starts at the correct row.
Tested with r133214.

[Yael]

Created attachment 171962 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 171962 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171962&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:211
>  
> -    transform.translate(-smartData->view.x, -smartData->view.y);
> -
>  #if USE(TILED_BACKING_STORE)
> +    transform.translate(-smartData->view.x / impl->pageViewportControllerClient()->scaleFactor(), -smartData->view.y / impl->pageViewportControllerClient()->scaleFactor());
>      IntPoint scrollPos = impl->pageViewportControllerClient()->scrollPosition();
>      transform.translate(scrollPos.x(), scrollPos.y());
>      transform.scale(1 / impl->pageViewportControllerClient()->scaleFactor());
> +#else
> +    transform.translate(-smartData->view.x, -smartData->view.y);
>  #endif

why not just translate it after the scale is applied. That would turn the #else into an #endif

[Yael]

Created attachment 172043 [details]
Patch

Address comment #2.

[Kenneth Rohde Christiansen]

Comment on attachment 172043 [details]
Patch

Much better! :-)

[Yael]

Committed in r133297 <http://trac.webkit.org/changeset/133297>

[Yael]

Comment on attachment 172043 [details]
Patch

Clearing flags.