Bug 100979 - Fix HAVE(NETWORK_CFDATA_ARRAY_CALLBACK) build
Summary: Fix HAVE(NETWORK_CFDATA_ARRAY_CALLBACK) build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-01 12:38 PDT by Alexey Proskuryakov
Modified: 2012-11-01 15:29 PDT (History)
7 users (show)

See Also:

Attachments
proposed patch (3.40 KB, patch)
2012-11-01 12:42 PDT, Alexey Proskuryakov 		joepeck: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
with more fixes (8.33 KB, patch)
2012-11-01 13:59 PDT, Alexey Proskuryakov 		joepeck: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2012-11-01 12:38:54 PDT 
Introduction of ResourceBuffer and some other recent changes have broken NETWORK_CFDATA_ARRAY_CALLBACK build on Mac.
Comment 1 Alexey Proskuryakov 2012-11-01 12:42:12 PDT 
Created attachment 171910 [details]
proposed patch
Comment 2 Joseph Pecoraro 2012-11-01 12:46:56 PDT 
Comment on attachment 171910 [details]
proposed patch

r=me
Comment 3 Build Bot 2012-11-01 13:02:02 PDT 
Comment on attachment 171910 [details]
proposed patch

Attachment 171910 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14661697
Comment 4 Alexey Proskuryakov 2012-11-01 13:59:20 PDT 
Created attachment 171923 [details]
with more fixes

Didn't realize that this could not be protected with USE(CF). Anyway, added some more fixes, so this needs new review.
Comment 5 Joseph Pecoraro 2012-11-01 14:02:32 PDT 
Comment on attachment 171923 [details]
with more fixes

View in context: https://bugs.webkit.org/attachment.cgi?id=171923&action=review

r=me

> Source/WTF/wtf/Platform.h:595
> +#define HAVE_NETWORK_CFDATA_ARRAY_CALLBACK 1 // FIXME: All CFNetwork based platforms have this callback now, so it should be USE, not HAVE.

I agree. Should you just change this now? Modifying Platform.h to have this comment will cause everyone to need to do a full build anyways.
Comment 6 Alexey Proskuryakov 2012-11-01 14:10:42 PDT 
I can do a global rename when landing, just didn't want it to complicate review.
Comment 7 Alexey Proskuryakov 2012-11-01 14:13:52 PDT 
Actually, I'd prefer to do it in a separate change landed immediately after.
Comment 8 Alexey Proskuryakov 2012-11-01 15:29:50 PDT 
Committed <http://trac.webkit.org/changeset/133232> and <http://trac.webkit.org/changeset/133233>