Bug 100978 - [BlackBerry] Add more form validation strings
Summary: [BlackBerry] Add more form validation strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-01 12:32 PDT by Rob Buis
Modified: 2012-11-01 15:00 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.94 KB, patch)
2012-11-01 14:13 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (2.85 KB, patch)
2012-11-01 14:15 PDT, Rob Buis
no flags Details | Formatted Diff | Diff
Patch (3.98 KB, patch)
2012-11-01 14:53 PDT, Rob Buis
yong.li.webkit: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2012-11-01 12:32:18 PDT
SSIA
Comment 1 Rob Buis 2012-11-01 14:13:34 PDT
Created attachment 171926 [details]
Patch
Comment 2 Rob Buis 2012-11-01 14:15:14 PDT
Created attachment 171928 [details]
Patch
Comment 3 Rob Buis 2012-11-01 14:53:40 PDT
Created attachment 171938 [details]
Patch
Comment 4 Yong Li 2012-11-01 14:55:13 PDT
Comment on attachment 171938 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171938&action=review

> Source/WebCore/platform/blackberry/LocalizedStringsBlackBerry.cpp:464
> +    return String::format(s_resource.getString(BlackBerry::Platform::VALIDATION_RANGE_UNDERFLOW), text.utf8().data());

it would be nice if we verify the format string in debug build, to make sure there is only one %, which is %s.
Comment 5 Yong Li 2012-11-01 14:55:28 PDT
(In reply to comment #4)
> (From update of attachment 171938 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=171938&action=review
> 
> > Source/WebCore/platform/blackberry/LocalizedStringsBlackBerry.cpp:464
> > +    return String::format(s_resource.getString(BlackBerry::Platform::VALIDATION_RANGE_UNDERFLOW), text.utf8().data());
> 
> it would be nice if we verify the format string in debug build, to make sure there is only one %, which is %s.

can be done in platform code.
Comment 6 Rob Buis 2012-11-01 15:00:15 PDT
Committed r133228: <http://trac.webkit.org/changeset/133228>