SSIA
Created attachment 171926 [details] Patch
Created attachment 171928 [details] Patch
Created attachment 171938 [details] Patch
Comment on attachment 171938 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171938&action=review > Source/WebCore/platform/blackberry/LocalizedStringsBlackBerry.cpp:464 > + return String::format(s_resource.getString(BlackBerry::Platform::VALIDATION_RANGE_UNDERFLOW), text.utf8().data()); it would be nice if we verify the format string in debug build, to make sure there is only one %, which is %s.
(In reply to comment #4) > (From update of attachment 171938 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=171938&action=review > > > Source/WebCore/platform/blackberry/LocalizedStringsBlackBerry.cpp:464 > > + return String::format(s_resource.getString(BlackBerry::Platform::VALIDATION_RANGE_UNDERFLOW), text.utf8().data()); > > it would be nice if we verify the format string in debug build, to make sure there is only one %, which is %s. can be done in platform code.
Committed r133228: <http://trac.webkit.org/changeset/133228>