Bug 100976 - [CSS Exclusions] Refactor ExclusionShapeInsideInfo to support shape outside & shape inside
Summary: [CSS Exclusions] Refactor ExclusionShapeInsideInfo to support shape outside &...
Status: RESOLVED DUPLICATE of bug 100766
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bear Travis
Depends on:
Reported: 2012-11-01 11:43 PDT by Bear Travis
Modified: 2013-03-01 15:09 PST (History)
0 users

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Bear Travis 2012-11-01 11:43:29 PDT
With shape outside on floats (bug 100398) it's become necessary to store shape info for both shape outside and shape inside.

Some suggestions for the patch:
computeShapeSize & m_shape can be lazily evaluated to avoid the m_shape asserts.
Names should be shorter, where possible.
The map add currently allocates a block every time when it doesn't need to.
The shape removal code may fail because a style has already been changed. Remove the test to make sure the shape is always removed.
Comment 1 Bear Travis 2013-03-01 15:09:02 PST
This was already fixed as part of the work on bug 100766.

*** This bug has been marked as a duplicate of bug 100766 ***