Bug 100972 - [Mac] Crash in Range::editingStartPosition
Summary: [Mac] Crash in Range::editingStartPosition
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-11-01 11:17 PDT by Ryosuke Niwa
Modified: 2012-11-01 12:02 PDT (History)
6 users (show)

See Also:

Attachments
Fixes the bug (1.75 KB, patch)
2012-11-01 11:20 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-11-01 11:17:05 PDT 
http://trac.webkit.org/browser/trunk/Source/WebCore/editing/mac/EditorMac.mm#L165
165	    RefPtr<Range> range = m_frame->selection()->toNormalizedRange();
166	    if (Node* startNode = adjustedSelectionStartForStyleComputation(m_frame->selection()->selection()).deprecatedNode()) {
167	        Node* pastEnd = range->pastLastNode();

range could be null in the line 165, in which case, we blow up in the line 167. We've been getting crash reports in Safari.

<rdar://problem/10227183>
Comment 1 Ryosuke Niwa 2012-11-01 11:20:59 PDT 
Created attachment 171898 [details]
Fixes the bug
Comment 2 WebKit Review Bot 2012-11-01 12:02:41 PDT 
Comment on attachment 171898 [details]
Fixes the bug

Clearing flags on attachment: 171898

Committed r133207: <http://trac.webkit.org/changeset/133207>
Comment 3 WebKit Review Bot 2012-11-01 12:02:46 PDT 
All reviewed patches have been landed.  Closing bug.