Bug 100971 - Add RGB to supported destination formats of ImageBuffer::copyToPlatformTexture
Summary: Add RGB to supported destination formats of ImageBuffer::copyToPlatformTexture
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on: 100714
Blocks: 100715
  Show dependency tree / graph
 
Reported: 2012-11-01 11:16 PDT by Kenneth Russell
Modified: 2012-11-01 11:54 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.11 KB, patch)
2012-11-01 11:20 PDT, Kenneth Russell 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2012-11-01 11:16:12 PDT 
In https://bugs.webkit.org/show_bug.cgi?id=100714 , ImageBuffer::copyToPlatformTexture was restricted to only work with RGBA/UNSIGNED_BYTE textures. It turns out this is too restrictive; it's necessary to allow RGB textures as well to allow existing applications to work without performance regressions.
Comment 1 Kenneth Russell 2012-11-01 11:20:50 PDT 
Created attachment 171897 [details]
Patch
Comment 2 Justin Novosad 2012-11-01 11:23:14 PDT 
(In reply to comment #1)
> Created an attachment (id=171897) [details]
> Patch

Does it resolve the problem described in comment 19 here: http://code.google.com/p/chromium/issues/detail?id=146219
Comment 3 Kenneth Russell 2012-11-01 11:23:44 PDT 
Yes, I manually verified with his test case that the fast path is taken.
Comment 4 Stephen White 2012-11-01 11:24:42 PDT 
Comment on attachment 171897 [details]
Patch

OK.  r=me
Comment 5 WebKit Review Bot 2012-11-01 11:54:01 PDT 
Comment on attachment 171897 [details]
Patch

Clearing flags on attachment: 171897

Committed r133202: <http://trac.webkit.org/changeset/133202>
Comment 6 WebKit Review Bot 2012-11-01 11:54:04 PDT 
All reviewed patches have been landed.  Closing bug.