Bug 100969 – [EFL][WK2] Remove redundant internal function

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Jinwoo Song]

ewk_view_text_found() in ewk_view.cpp is not used anymore, so we can remove it.

[Jinwoo Song]

Created attachment 171883 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 171883 [details]
Patch

In ewk_view_text_matches_count(), there is below comment. Don't you need to send this signal rather than to remove this ?

 * The "text,found" callback will be called with the number of matched string.

EAPI Eina_Bool ewk_view_text_matches_count(Evas_Object *o, const char *text, Ewk_Find_Options options, unsigned max_match_count);

[Jinwoo Song]

"text,found" callback is emitted from didFindString in FindClientEfl.cpp.

void FindClientEfl::didFindString(WKPageRef, WKStringRef, unsigned matchCount, const void* clientInfo)
{
    FindClientEfl* findClient = toFindClientEfl(clientInfo);
    findClient->m_viewImpl->smartCallback<TextFound>().call(&matchCount);
}

FindClientEfl::FindClientEfl(EwkViewImpl* viewImpl)
    : m_viewImpl(viewImpl)
{
...
    findClient.didCountStringMatches = didFindString;
...
} 

As you know, smart callback call has been refactored, so ewk_view_text_found() is not used anymore.

[Gyuyoung Kim]

Comment on attachment 171883 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171883&action=review

Yes, right. Thanks.

> Source/WebKit2/ChangeLog:8
> +        Remove ewk_view_text_found() in ewk_view.cpp which is not used anymore.

It would be good if you say this signal is emitted by DECLARE_EWK_VIEW_CALLBACK(TextFound, "text,found", unsigned) in EwkViewCallback.h instead.

[Chris Dumez]

Comment on attachment 171883 [details]
Patch

Right, we missed this one. Thanks. LGTM.

[Jinwoo Song]

(In reply to comment #4)
> (From update of attachment 171883 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=171883&action=review
> 
> Yes, right. Thanks.
> 
> > Source/WebKit2/ChangeLog:8
> > +        Remove ewk_view_text_found() in ewk_view.cpp which is not used anymore.
> 
> It would be good if you say this signal is emitted by DECLARE_EWK_VIEW_CALLBACK(TextFound, "text,found", unsigned) in EwkViewCallback.h instead.

I'll update the ChangeLog as your advice.

[Jinwoo Song]

Created attachment 171987 [details]
Patch

[WebKit Review Bot]

Comment on attachment 171987 [details]
Patch

Clearing flags on attachment: 171987

Committed r133269: <http://trac.webkit.org/changeset/133269>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.