Bug 100965 - [V8] The DOMWrapperVisitor abstraction is no longer needed
Summary: [V8] The DOMWrapperVisitor abstraction is no longer needed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on: 100963
Blocks:
  Show dependency tree / graph
 
Reported: 2012-11-01 09:36 PDT by Adam Barth
Modified: 2012-11-01 10:48 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.76 KB, patch)
2012-11-01 09:39 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (6.71 KB, patch)
2012-11-01 09:58 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (6.51 KB, patch)
2012-11-01 09:59 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-11-01 09:36:13 PDT 
[V8] The DOMWrapperVisitor abstraction is no longer needed
Comment 1 Adam Barth 2012-11-01 09:39:21 PDT 
Created attachment 171874 [details]
Patch
Comment 2 Kentaro Hara 2012-11-01 09:43:08 PDT 
Comment on attachment 171874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171874&action=review

> Source/WebCore/bindings/v8/ScriptProfiler.cpp:215
> +    class VisitorAdapter : public v8::PersistentHandleVisitor {

Nit: I would slightly prefer DOMObjectWrapperVisitor than VisitorAdapter. Also you can rename VisitorAdaptor for Nodes to DOMNodeWrapperVisitor.
Comment 3 Adam Barth 2012-11-01 09:57:44 PDT 
Done.
Comment 4 Adam Barth 2012-11-01 09:58:48 PDT 
Created attachment 171881 [details]
Patch for landing
Comment 5 Adam Barth 2012-11-01 09:59:37 PDT 
Created attachment 171882 [details]
Patch
Comment 6 WebKit Review Bot 2012-11-01 10:48:53 PDT 
Comment on attachment 171882 [details]
Patch

Clearing flags on attachment: 171882

Committed r133194: <http://trac.webkit.org/changeset/133194>
Comment 7 WebKit Review Bot 2012-11-01 10:48:57 PDT 
All reviewed patches have been landed.  Closing bug.