Bug 100960 – [BlackBerry] Use clipped background rect in backing store

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Leo Yang]

1190 void BackingStorePrivate::paintDefaultBackground(const Platform::IntRect& dstRect, Platform::ViewportAccessor* viewportAccessor, bool flush)
1191 {
1192     Platform::IntRect clippedDstRect = dstRect;
1193 
1194     // Because of rounding it is possible that overScrollRect could be off-by-one larger
1195     // than the surface size of the window. We prevent this here, by clamping
1196     // it to ensure that can't happen.
1197     clippedDstRect.intersect(Platform::IntRect(Platform::IntPoint(0, 0), surfaceSize()));
1198 
1199     if (clippedDstRect.isEmpty())
1200         return;
1201 
1202     // We have to paint the default background in the case of overzoom and
1203     // make sure it is invalidated.
1204     const Platform::IntRect pixelContentsRect = viewportAccessor->pixelContentsRect();
1205     Platform::IntRectRegion overScrollRegion = Platform::IntRectRegion::subtractRegions(
1206         dstRect, viewportAccessor->pixelViewportFromContents(pixelContentsRect));

In line 1206 it is wrongly using unclipped back ground destination rect which cause platform code ASSERT.

[Leo Yang]

Created attachment 171862 [details]
Patch

[Yong Li]

Comment on attachment 171862 [details]
Patch

r+/cq+ as it is internally reviewed by Arvid

[WebKit Review Bot]

Comment on attachment 171862 [details]
Patch

Clearing flags on attachment: 171862

Committed r133184: <http://trac.webkit.org/changeset/133184>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.