WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
100944
Output Android's device status before running tests on the bots
https://bugs.webkit.org/show_bug.cgi?id=100944
Summary
Output Android's device status before running tests on the bots
Peter Beverloo
Reported
2012-11-01 05:07:27 PDT
Output Android's device status before running tests on the bots
Attachments
Patch
(6.70 KB, patch)
2012-11-01 05:09 PDT
,
Peter Beverloo
no flags
Details
Formatted Diff
Diff
Patch
(6.82 KB, patch)
2012-11-02 03:42 PDT
,
Peter Beverloo
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Peter Beverloo
Comment 1
2012-11-01 05:09:44 PDT
Created
attachment 171817
[details]
Patch
Tony Chang
Comment 2
2012-11-01 10:57:59 PDT
Comment on
attachment 171817
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=171817&action=review
> Tools/ChangeLog:19 > + * Scripts/output-android-device-status: Added.
Can we move this script to Tools/BuildSlaveSupport/chromium/output-android-device-status since it's for the bots?
> Tools/Scripts/output-android-device-status:81 > +if __name__ == '__main__': > + sys.exit(main())
Nit: indent 4 spaces.
Peter Beverloo
Comment 3
2012-11-02 03:42:22 PDT
Created
attachment 172028
[details]
Patch
Peter Beverloo
Comment 4
2012-11-02 03:43:38 PDT
Comment on
attachment 172028
[details]
Patch Dirk: Thanks for the review! Tony: Good idea, thank you! I've moved the file to that directory, and added two spaces to properly indent it.
WebKit Review Bot
Comment 5
2012-11-02 08:16:27 PDT
Comment on
attachment 172028
[details]
Patch Clearing flags on attachment: 172028 Committed
r133299
: <
http://trac.webkit.org/changeset/133299
>
WebKit Review Bot
Comment 6
2012-11-02 08:16:30 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug