RESOLVED FIXED 100943
Whitespace in particular source code changes rendering; does not in Firefox
https://bugs.webkit.org/show_bug.cgi?id=100943
Summary Whitespace in particular source code changes rendering; does not in Firefox
Lucas Buetto
Reported 2012-11-01 04:23:49 PDT
I found a problem that occurs only when I am using indentation of code. Turning the html code I am enclosing note that the 'first instance' icons are going to line the bottom of the div where he is. I noticed that this happens only when my code is indented as in the example below: <div class="ComboBox"> <span>System</ span> <span class="ComboIcon IconComboDown"></ span> </div> But in 'Second Example' the problem ceases to be because I removed the indentation of code, leaving him as the example below: <div class="ComboBox"><span>System</span><span class="ComboIcon IconComboDown"></span></div> User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.4 (KHTML, like Gecko) Safari/537.4 Chrome/22.0.1229.94. The problem occurs with the browsers: - Using Safari Version: 5.1.7 (7534.57.2). - Google Chrome 22.0.1229.94 (Official Build 161065) m
Attachments
stand-alone reduction (2.63 KB, text/html)
2012-11-01 10:32 PDT, Eric Seidel (no email)
no flags
patch proposal (6.29 KB, patch)
2013-03-11 15:22 PDT, arno.
no flags
Adam Barth
Comment 1 2012-11-01 10:09:34 PDT
> <div class="ComboBox"> > <span>System</ span> > <span class="ComboIcon IconComboDown"></ span> > </div> Is there CSS that uses these class attributes? Also, you seem to have an extra space between the "</" and the "span" in this version but not in the other version. Is that important to the example?
Eric Seidel (no email)
Comment 2 2012-11-01 10:32:05 PDT
Created attachment 171889 [details] stand-alone reduction
Eric Seidel (no email)
Comment 3 2012-11-01 10:37:14 PDT
Yup, this is a layout bug, not a parser bug as far as I can tell.
Levi Weintraub
Comment 4 2012-11-01 10:51:04 PDT
Awaiting a final patch on the other bug. *** This bug has been marked as a duplicate of bug 99442 ***
Alexey Proskuryakov
Comment 5 2012-11-01 10:54:45 PDT
This bug is not a recent regression. Is it correct that it got marked as a duplicate of recent regression?
Eric Seidel (no email)
Comment 6 2012-11-01 11:00:51 PDT
I guess the question is if it is fixed by bug 99442 or not. I don't know the answer to that.
Levi Weintraub
Comment 7 2012-11-02 05:46:38 PDT
You're right in that this isn't a regression. My mistake marking it a duplicate, it's not.
arno.
Comment 8 2013-03-11 15:22:01 PDT
Created attachment 192574 [details] patch proposal
Darin Adler
Comment 9 2013-04-09 09:20:33 PDT
Comment on attachment 192574 [details] patch proposal I think this is right. Would be even better if a true rendering expert reviewed it, but we can always roll it out if they disagree.
WebKit Commit Bot
Comment 10 2013-04-09 09:45:18 PDT
Comment on attachment 192574 [details] patch proposal Clearing flags on attachment: 192574 Committed r148027: <http://trac.webkit.org/changeset/148027>
WebKit Commit Bot
Comment 11 2013-04-09 09:45:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.