Bug 100943 - Whitespace in particular source code changes rendering; does not in Firefox
Summary: Whitespace in particular source code changes rendering; does not in Firefox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 525.x (Safari 3.2)
Hardware: All All
: P2 Normal
Assignee: arno.
URL: http://www.bdacriacoes.com.br/googlec...
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-01 04:23 PDT by Lucas Buetto
Modified: 2013-04-09 09:45 PDT (History)
12 users (show)

See Also:

Attachments
stand-alone reduction (2.63 KB, text/html)
2012-11-01 10:32 PDT, Eric Seidel (no email) 		no flags Details
patch proposal (6.29 KB, patch)
2013-03-11 15:22 PDT, arno. 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Buetto 2012-11-01 04:23:49 PDT 
I found a problem that occurs only when I am using indentation of code.
Turning the html code I am enclosing note that the 'first instance' icons are going to line the bottom of the div where he is. I noticed that this happens only when my code is indented as in the example below:

<div class="ComboBox">
 <span>System</ span>
 <span class="ComboIcon IconComboDown"></ span>
</div>


But in 'Second Example' the problem ceases to be because I removed the indentation of code, leaving him as the example below:

<div class="ComboBox"><span>System</span><span class="ComboIcon IconComboDown"></span></div>


User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.4 (KHTML, like Gecko) Safari/537.4 Chrome/22.0.1229.94.

The problem occurs with the browsers:
- Using Safari Version: 5.1.7 (7534.57.2).
- Google Chrome 22.0.1229.94 (Official Build 161065) m
Comment 1 Adam Barth 2012-11-01 10:09:34 PDT 
> <div class="ComboBox">
>  <span>System</ span>
>  <span class="ComboIcon IconComboDown"></ span>
> </div>

Is there CSS that uses these class attributes?  Also, you seem to have an extra space between the "</" and the "span" in this version but not in the other version.  Is that important to the example?
Comment 2 Eric Seidel (no email) 2012-11-01 10:32:05 PDT 
Created attachment 171889 [details]
stand-alone reduction
Comment 3 Eric Seidel (no email) 2012-11-01 10:37:14 PDT 
Yup, this is a layout bug, not a parser bug as far as I can tell.
Comment 4 Levi Weintraub 2012-11-01 10:51:04 PDT 
Awaiting a final patch on the other bug.

*** This bug has been marked as a duplicate of bug 99442 ***
Comment 5 Alexey Proskuryakov 2012-11-01 10:54:45 PDT 
This bug is not a recent regression. Is it correct that it got marked as a duplicate of recent regression?
Comment 6 Eric Seidel (no email) 2012-11-01 11:00:51 PDT 
I guess the question is if it is fixed by bug 99442 or not.  I don't know the answer to that.
Comment 7 Levi Weintraub 2012-11-02 05:46:38 PDT 
You're right in that this isn't a regression. My mistake marking it a duplicate, it's not.
Comment 8 arno. 2013-03-11 15:22:01 PDT 
Created attachment 192574 [details]
patch proposal
Comment 9 Darin Adler 2013-04-09 09:20:33 PDT 
Comment on attachment 192574 [details]
patch proposal

I think this is right. Would be even better if a true rendering expert reviewed it, but we can always roll it out if they disagree.
Comment 10 WebKit Commit Bot 2013-04-09 09:45:18 PDT 
Comment on attachment 192574 [details]
patch proposal

Clearing flags on attachment: 192574

Committed r148027: <http://trac.webkit.org/changeset/148027>
Comment 11 WebKit Commit Bot 2013-04-09 09:45:22 PDT 
All reviewed patches have been landed.  Closing bug.