RESOLVED FIXED 100894
Implement optional arguments in AudioBufferSourceNode start() method 
https://bugs.webkit.org/show_bug.cgi?id=100894
Summary Implement optional arguments in AudioBufferSourceNode start() method
Chris Rogers
Reported 2012-10-31 14:55:26 PDT
Implement optional arguments in AudioBufferSourceNode start() method
Attachments
Patch (17.34 KB, patch)
2012-10-31 15:02 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2012-10-31 15:02:48 PDT
Created attachment 171727 [details] Patch
Kenneth Russell
Comment 2 2012-10-31 15:09:39 PDT
Comment on attachment 171727 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171727&action=review Looks good. One minor comment. r=me > LayoutTests/webaudio/audiobuffersource-start.html:62 > + if (test.offsetFrame == "none" && test.durationFrames == "none") { You could consider leaving these properties undefined and check for "=== undefined". Not a big deal either way, but a simple typo in the string "none" could cause bugs.
Chris Rogers
Comment 3 2012-10-31 15:38:25 PDT
Comment on attachment 171727 [details] Patch Thanks Ken, leaving as "none" for now just to make it more clear in the test vectors exactly what's going on
WebKit Review Bot
Comment 4 2012-10-31 17:39:59 PDT
Comment on attachment 171727 [details] Patch Clearing flags on attachment: 171727 Committed r133101: <http://trac.webkit.org/changeset/133101>
WebKit Review Bot
Comment 5 2012-10-31 17:40:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.