Bug 100894 - Implement optional arguments in AudioBufferSourceNode start() method
Summary: Implement optional arguments in AudioBufferSourceNode start() method
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-31 14:55 PDT by Chris Rogers
Modified: 2012-10-31 17:40 PDT (History)
6 users (show)

See Also:

Attachments
Patch (17.34 KB, patch)
2012-10-31 15:02 PDT, Chris Rogers 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2012-10-31 14:55:26 PDT 
Implement optional arguments in AudioBufferSourceNode start() method
Comment 1 Chris Rogers 2012-10-31 15:02:48 PDT 
Created attachment 171727 [details]
Patch
Comment 2 Kenneth Russell 2012-10-31 15:09:39 PDT 
Comment on attachment 171727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171727&action=review

Looks good. One minor comment. r=me

> LayoutTests/webaudio/audiobuffersource-start.html:62
> +    if (test.offsetFrame == "none" && test.durationFrames == "none") {

You could consider leaving these properties undefined and check for "=== undefined". Not a big deal either way, but a simple typo in the string "none" could cause bugs.
Comment 3 Chris Rogers 2012-10-31 15:38:25 PDT 
Comment on attachment 171727 [details]
Patch

Thanks Ken, leaving as "none" for now just to make it more clear in the test vectors exactly what's going on
Comment 4 WebKit Review Bot 2012-10-31 17:39:59 PDT 
Comment on attachment 171727 [details]
Patch

Clearing flags on attachment: 171727

Committed r133101: <http://trac.webkit.org/changeset/133101>
Comment 5 WebKit Review Bot 2012-10-31 17:40:02 PDT 
All reviewed patches have been landed.  Closing bug.