Bug 100887 - [chromium] platform/chromium/accessibility/other-aria-attribute-change-sends-notification.html failing
Summary: [chromium] platform/chromium/accessibility/other-aria-attribute-change-sends-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-31 14:24 PDT by Stephen White
Modified: 2012-11-02 14:29 PDT (History)
8 users (show)

See Also:


Attachments
Patch (9.68 KB, patch)
2012-11-02 13:19 PDT, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen White 2012-10-31 14:24:58 PDT
Started failing after r133069.

Looks like it just changed the order of TEXT results, so probably can be rebaselined:

E.g., 

--- /mnt/data/b/build/slave/WebKit_Linux/build/layout-test-results/platform/chromium/accessibility/other-aria-attribute-change-sends-notification-expected.txt 
+++ /mnt/data/b/build/slave/WebKit_Linux/build/layout-test-results/platform/chromium/accessibility/other-aria-attribute-change-sends-notification-actual.txt 
@@ -4,12 +4,12 @@
 
 
 
-PASS successfullyParsed is true
-
-TEST COMPLETE
 Got AriaAttributeChanged notification on aria-busy
 Got AriaAttributeChanged notification on aria-disabled
 Got AriaAttributeChanged notification on aria-readonly
 Got AriaAttributeChanged notification on aria-required
 All notifications received successfully.
+PASS successfullyParsed is true
 
+TEST COMPLETE
+
Comment 1 Stephen White 2012-10-31 14:29:31 PDT
platform/chromium/accessibility/is-ignored-change-sends-notification.html also failing w/similar symptoms (just changes order of text results).
Comment 2 Tony Chang 2012-10-31 14:33:11 PDT
The tests are manually calling waitUntilDone/notifyDone instead of setting window.jsTestIsAsync = true.  That should delay the call to finishJSTest which writes those log lines.
Comment 3 Stephen White 2012-10-31 15:25:19 PDT
Added platform/chromium/accessibility/text-change-notification.html.

Now that we have more data, it looks like they're actually flaky since the cacheing change.  Marked as such.  Looks like this'll need an actual fix.
Comment 4 Tony Chang 2012-11-02 13:19:40 PDT
Created attachment 172122 [details]
Patch
Comment 5 WebKit Review Bot 2012-11-02 14:29:00 PDT
Comment on attachment 172122 [details]
Patch

Clearing flags on attachment: 172122

Committed r133347: <http://trac.webkit.org/changeset/133347>
Comment 6 WebKit Review Bot 2012-11-02 14:29:05 PDT
All reviewed patches have been landed.  Closing bug.