Modify portions of Chromium WebKit to use the embedder-provided gesture curves.
Created attachment 171713 [details] Patch
Created attachment 174520 [details] Patch
Comment on attachment 174520 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174520&action=review > Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp:209 > + m_wheelFlingCurve = WTF::adoptPtr(Platform::current()->createFlingAnimationCurve(gestureEvent.data.flingStart.sourceDevice, WebFloatPoint(gestureEvent.data.flingStart.velocityX, gestureEvent.data.flingStart.velocityY), WebSize())); WTF:: <--- no need for the WTF prefix.
Attachment 174520 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1 Source/WebKit/chromium/src/WebViewImpl.h:123: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 174533 [details] Patch
Is the style-bot being silly? I've written the change preserves the spacing that was there. Or should I relayout the code? And abarth: your suggestion made in p3.
Attachment 174533 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1 Source/WebKit/chromium/src/WebViewImpl.h:123: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 174533 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=174533&action=review R=me > Source/WebKit/chromium/src/WebViewImpl.cpp:698 > // FIXME: Make the curve parametrizable from the browser. > - OwnPtr<PlatformGestureCurve> flingCurve = PlatformGestureCurveFactory::get()->createCurve(event.data.flingStart.sourceDevice, FloatPoint(event.data.flingStart.velocityX, event.data.flingStart.velocityY)); > - m_gestureAnimation = ActivePlatformGestureAnimation::create(flingCurve.release(), this); > + OwnPtr<WebGestureCurve> flingCurve = adoptPtr(Platform::current()->createFlingAnimationCurve(event.data.flingStart.sourceDevice, WebFloatPoint(event.data.flingStart.velocityX, event.data.flingStart.velocityY), WebSize())); I think you can remove the FIXME here now, right? >> Source/WebKit/chromium/src/WebViewImpl.h:123 >> + , public WebGestureCurveTarget > > Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] I think it's being a bit silly here, although this method of listing base classes is a bit unorthodox.
Created attachment 175281 [details] Patch
Comment on attachment 175281 [details] Patch Clearing flags on attachment: 175281 Committed r135318: <http://trac.webkit.org/changeset/135318>
All reviewed patches have been landed. Closing bug.