Bug 100875 – [chromium] Make WebLayerTreeView::adjustEventPointForPinchZoom pure virtual.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[W. James MacLean]

[chromium] Make WebLayerTreeView::adjustEventPointForPinchZoom pure virtual.

[W. James MacLean]

Created attachment 171701 [details]
Patch

[W. James MacLean]

Removing a default function implementation that was necessary to land a multi-sided patch.

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[James Robinson]

Comment on attachment 171701 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171701&action=review

Have you rolled the implementation into Source/WebKit/chromium/DEPS?

> Source/Platform/chromium/public/WebLayerTreeView.h:101
> +    virtual WebFloatPoint adjustEventPointForPinchZoom(const WebFloatPoint&) const =0;

need a space before the 0

[W. James MacLean]

(In reply to comment #4)
> (From update of attachment 171701 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=171701&action=review
> 
> Have you rolled the implementation into Source/WebKit/chromium/DEPS?

Not yet, but will do it prior to submitting this.

> > Source/Platform/chromium/public/WebLayerTreeView.h:101
> > +    virtual WebFloatPoint adjustEventPointForPinchZoom(const WebFloatPoint&) const =0;
> 
> need a space before the 0

Thx, fixed.

[Peter Beverloo (cr-android ews)]

Comment on attachment 171701 [details]
Patch

Attachment 171701 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/14678248

[W. James MacLean]

(In reply to comment #6)
> (From update of attachment 171701 [details])
> Attachment 171701 [details] did not pass cr-android-ews (chromium-android):
> Output: http://queues.webkit.org/results/14678248

This is presumably because the implementation of adjustEventPointForPinchZoom() doesn't exist in LKGR? I'm waiting for that to catch up so I can roll webkit-chromium DEPS and then I'll land this.

[kov's GTK+ EWS bot]

Comment on attachment 171701 [details]
Patch

Attachment 171701 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/14696059

[James Robinson]

(In reply to comment #7)
> (In reply to comment #6)
> > (From update of attachment 171701 [details] [details])
> > Attachment 171701 [details] [details] did not pass cr-android-ews (chromium-android):
> > Output: http://queues.webkit.org/results/14678248
> 
> This is presumably because the implementation of adjustEventPointForPinchZoom() doesn't exist in LKGR? I'm waiting for that to catch up so I can roll webkit-chromium DEPS and then I'll land this.

These bots don't care about LKGR, just about Source/WebKit/chromium/DEPS

[WebKit Review Bot]

Comment on attachment 171701 [details]
Patch

Attachment 171701 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14684267

[W. James MacLean]

(In reply to comment #9)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > (From update of attachment 171701 [details] [details] [details])
> > > Attachment 171701 [details] [details] [details] did not pass cr-android-ews (chromium-android):
> > > Output: http://queues.webkit.org/results/14678248
> > 
> > This is presumably because the implementation of adjustEventPointForPinchZoom() doesn't exist in LKGR? I'm waiting for that to catch up so I can roll webkit-chromium DEPS and then I'll land this.
> 
> These bots don't care about LKGR, just about Source/WebKit/chromium/DEPS

OK, so basically the same issue. In future I'll make sure I roll chromium/DEPS first, then send the cl through the bots.

[WebKit Review Bot]

Comment on attachment 171701 [details]
Patch

Rejecting attachment 171701 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
platform/chromium/TestExpectations
Auto-merging Source/WebKit2/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 [Chromium] Unreviewed gardening.  New reftest from

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 154.

Full output: http://queues.webkit.org/results/14692522

[W. James MacLean]

Created attachment 171860 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 171860 [details]
Patch for landing

Clearing flags on attachment: 171860

Committed r133185: <http://trac.webkit.org/changeset/133185>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.