Bug 100864 - [NRWT] Xvfb driver is leaking application cache files
Summary: [NRWT] Xvfb driver is leaking application cache files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago Marcos P. Santos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-31 08:48 PDT by Thiago Marcos P. Santos
Modified: 2012-11-02 14:30 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.56 KB, patch)
2012-10-31 09:11 PDT, Thiago Marcos P. Santos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Marcos P. Santos 2012-10-31 08:48:46 PDT
By setting XDG_CACHE_HOME to self._port.results_directory() will make the worker reuse the cache of some previous and potentially taint the results. It should be set to the work's temporary directory instead, which is removed after the run.

Currently the Application Cache is the only to respect this environment variable on WebKit2 because there is no API to override the path like it is usually done on DRT and WTR.
Comment 1 Thiago Marcos P. Santos 2012-10-31 09:11:38 PDT
Created attachment 171671 [details]
Patch
Comment 2 WebKit Review Bot 2012-10-31 11:29:04 PDT
Comment on attachment 171671 [details]
Patch

Clearing flags on attachment: 171671

Committed r133050: <http://trac.webkit.org/changeset/133050>
Comment 3 WebKit Review Bot 2012-10-31 11:29:08 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Stephen White 2012-11-02 13:50:35 PDT
This change seems to be causing failures in the chromium port's webkitpy-test; e.g., see

http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/31058/steps/webkitpy-test/logs/stdio

"Seems" because it's the only xvfb-related change in the first failing run:

http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/31058
Comment 5 Thiago Marcos P. Santos 2012-11-02 14:27:54 PDT
(In reply to comment #4)
> This change seems to be causing failures in the chromium port's webkitpy-test; e.g., see
> 
> http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/31058/steps/webkitpy-test/logs/stdio
> 
> "Seems" because it's the only xvfb-related change in the first failing run:
> 
> http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/31058

Hmmm, weird. The patch just changes a environment variable path. Is the Windows bot really suppose to start the Xvfb server?
Comment 6 Adam Barth 2012-11-02 14:29:45 PDT
> Is the Windows bot really suppose to start the Xvfb server?

It looks like something isn't properly mocking out the file system.
Comment 7 Adam Barth 2012-11-02 14:30:34 PDT
It's also possible we should skip this test on Windows.