Bug 100861 - [chromium] Enable RESOLUTION_MEDIA_QUERY
Summary: [chromium] Enable RESOLUTION_MEDIA_QUERY
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rick Byers
URL:
Keywords: WebExposed
Depends on: 99077 100865
Blocks:
  Show dependency tree / graph
 
Reported: 2012-10-31 07:49 PDT by Rick Byers
Modified: 2013-04-09 17:07 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rick Byers 2012-10-31 07:49:03 PDT 
Kenneth recently landed support for 'resolution' media queries and dppx units (bug 99077). I think we should enable it in chromium.
Comment 1 Peter Beverloo 2012-10-31 07:52:20 PDT 
We'll need ENABLE_CSS_IMAGE_RESOLUTION as well as it depends on that.

I do completely concur for Android, but johnme@ has some concerns regarding the units we'd expose.
Comment 2 Rick Byers 2012-10-31 07:57:04 PDT 
(In reply to comment #1)
> We'll need ENABLE_CSS_IMAGE_RESOLUTION as well as it depends on that.

Are you sure?  From the code it looked to me like it was perhaps designed to work without it.  Anyway I will give it a try sometime soon (just some higher priority things in my queue first).

> I do completely concur for Android, but johnme@ has some concerns regarding the units we'd expose.

Great, let's discuss any concerns.  Tab has been working on the spec, so I hope he's already been made aware of any concerns chromium folks have with it.
Comment 3 Peter Beverloo 2012-10-31 08:04:16 PDT 
(In reply to comment #2)
> Are you sure?  From the code it looked to me like it was perhaps designed to work without it.  Anyway I will give it a try sometime soon (just some higher priority things in my queue first).

I should read patches more carefully :-). You're right, thanks!
Comment 4 Kenneth Rohde Christiansen 2012-10-31 08:16:33 PDT 
Be aware that Chromium needs to stop forwarding the actual device dpi to the screen.vertical|horizontalDPI methods.
Comment 5 John Mellor 2012-10-31 09:44:58 PDT 
(In reply to comment #2)
> (In reply to comment #1)
> > I do completely concur for Android, but johnme@ has some concerns regarding the units we'd expose.
> 
> Great, let's discuss any concerns.  Tab has been working on the spec, so I hope he's already been made aware of any concerns chromium folks have with it.

I filed bug 100865 about this.

(In reply to comment #4)
> Be aware that Chromium needs to stop forwarding the actual device dpi to the screen.vertical|horizontalDPI methods.

Why do we need to stop this? And what should we do instead?
Comment 6 Kenneth Rohde Christiansen 2012-10-31 10:34:26 PDT 
(In reply to comment #5)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > I do completely concur for Android, but johnme@ has some concerns regarding the units we'd expose.
> > 
> > Great, let's discuss any concerns.  Tab has been working on the spec, so I hope he's already been made aware of any concerns chromium folks have with it.
> 
> I filed bug 100865 about this.
> 
> (In reply to comment #4)
> > Be aware that Chromium needs to stop forwarding the actual device dpi to the screen.vertical|horizontalDPI methods.
> 
> Why do we need to stop this? And what should we do instead?

As far as I can tell you are not using it for anything (via that api) and the values are also not exposed to the web content (not declared in the idl).

So I don't think you need to do anything instead.
Comment 7 Stephen Chenney 2013-04-09 17:07:32 PDT 
Marked LayoutTest bugs, bugs with Chromium IDs, and some others as WontFix. Test failure bugs still are trackable via TestExpectations or disabled unit tests.