Define ACCESSIBILITY macro. Support for ATK library.
Created attachment 172772 [details] [EFL] Platform support for Accessibility feature.
Comment on attachment 172772 [details] [EFL] Platform support for Accessibility feature. Attachment 172772 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/14755467
This patch enables support for Accessibility feature in WebCore. In general, core Accessibility implementation will be shared with gtk see: https://bugs.webkit.org/show_bug.cgi?id=99578 Having some problems regarding global HAVE_ACCESSIBILITY macro, temporarily a11y is enabled by default till I deliver proper fixes.
*** Bug 99156 has been marked as a duplicate of this bug. ***
EFL bot is red because of the dependency problem. It should wait for (99578). > Having some problems regarding global HAVE_ACCESSIBILITY macro, temporarily a11y is enabled by default till I deliver proper fixes. I thought about a flag that enables Accessibility for EFL. Implementing this, I had some compilation errors because of the missing HAVE_ACCESSIBILITY macro in some places. As soon as this patch lands in mainstream, I propose fix for this problem.
(In reply to comment #5) > EFL bot is red because of the dependency problem. It should wait for (99578). bug 99578 landed, at the moment we shouldn't have any compilation issues. > > Having some problems regarding global HAVE_ACCESSIBILITY macro, temporarily a11y is enabled by default till I deliver proper fixes. > > I thought about a flag that enables Accessibility for EFL. Implementing this, I had some compilation errors because of the missing HAVE_ACCESSIBILITY macro in some places. As soon as this patch lands in mainstream, I propose fix for this problem. I am in favor of features that can be manipulated during compilation, especially if they require dependency like atk etc. Actually, in this way we implemented spelling for WK2-EFL. If you are going to add possibility to turn off accessibility feature for WK-EFL please open separate bug and set proper dependency as this patch blocks another bug (bug 100757).
I created new bug for turning off accessibility for WebKit-EFL. https://bugs.webkit.org/show_bug.cgi?id=103036
I installed libatk1.0-dev to efl ews. Please re-submit.
Created attachment 175633 [details] [EFL] Platform support for Accessibility feature.
(In reply to comment #8) > I installed libatk1.0-dev to efl ews. Dominik, could you install it on Intel bots too? Thanks.
LGTM.
Comment on attachment 175633 [details] [EFL] Platform support for Accessibility feature. Is there any unskip test cases by this patch ?
(In reply to comment #12) > (From update of attachment 175633 [details]) > Is there any unskip test cases by this patch ? All the accessibility tests cases are skipped at the moment. There's a bug (100757) that adds some platform specific changes to WTR. I think as soon those 2 patches will land it. We can try to unskip some accessibility tests.
Comment on attachment 175633 [details] [EFL] Platform support for Accessibility feature. View in context: https://bugs.webkit.org/attachment.cgi?id=175633&action=review > Source/cmake/OptionsEfl.cmake:194 > + As laszlo pointed out, please add ENABLE_ACCESSIBILITY to here soon.
Beside you need to add libatk1.0-dev to dependencies in http://trac.webkit.org/wiki/EFLWebKit
(In reply to comment #14) > (From update of attachment 175633 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=175633&action=review > > > Source/cmake/OptionsEfl.cmake:194 > > + > > As laszlo pointed out, please add ENABLE_ACCESSIBILITY to here soon. I already opened a ticket for it (103036). I will do this very soon.Thanks.
Comment on attachment 175633 [details] [EFL] Platform support for Accessibility feature. Clearing flags on attachment: 175633 Committed r135569: <http://trac.webkit.org/changeset/135569>
All reviewed patches have been landed. Closing bug.