Bug 100846 - [JSC] Web Inspector: support Debugger.pause for dedicated workers
Summary: [JSC] Web Inspector: support Debugger.pause for dedicated workers
Status: RESOLVED DUPLICATE of bug 164136
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-10-31 06:14 PDT by Yury Semikhatsky
Modified: 2016-11-17 14:37 PST (History)
16 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-10-31 06:14:36 PDT
Pause command should worker for dedicated workers in JSC.
Comment 1 Peter Wang 2012-11-19 00:49:59 PST
So far, the Pause commands are same for shared and dedicated worker of JSC, it just set a flag to let JSC engine to stop on next statement.

Are there some special cases have to be considered? Please give some tips, thank you very much.
Comment 2 Yury Semikhatsky 2012-11-19 01:07:28 PST
(In reply to comment #1)
> So far, the Pause commands are same for shared and dedicated worker of JSC, it just set a flag to let JSC engine to stop on next statement.
> 
> Are there some special cases have to be considered? Please give some tips, thank you very much.

The pause command should work even if the worker is in a tight loop so that we can pause long-running scripts. Apart from that there is nothing special about the pause for workers.

There is a sanity test for pause in dedicated worker that didn't work in JSC last time I checked that(LayoutTests/inspector-protocol/debugger-pause-dedicated-worker.html). This may have changed after your recent changes to WorkerScriptDebugServer.
Comment 3 Peter Wang 2012-11-19 01:11:13 PST
(In reply to comment #2)
> (In reply to comment #1)
> > So far, the Pause commands are same for shared and dedicated worker of JSC, it just set a flag to let JSC engine to stop on next statement.
> > 
> > Are there some special cases have to be considered? Please give some tips, thank you very much.
> 
> The pause command should work even if the worker is in a tight loop so that we can pause long-running scripts. Apart from that there is nothing special about the pause for workers.
> 
> There is a sanity test for pause in dedicated worker that didn't work in JSC last time I checked that(LayoutTests/inspector-protocol/debugger-pause-dedicated-worker.html). This may have changed after your recent changes to WorkerScriptDebugServer.

Ok, I'll check it and report the newest situation here. Thank you.
Comment 4 Peter Wang 2012-11-19 02:02:10 PST
(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > So far, the Pause commands are same for shared and dedicated worker of JSC, it just set a flag to let JSC engine to stop on next statement.
> > > 
> > > Are there some special cases have to be considered? Please give some tips, thank you very much.
> > 
> > The pause command should work even if the worker is in a tight loop so that we can pause long-running scripts. Apart from that there is nothing special about the pause for workers.
> > 
> > There is a sanity test for pause in dedicated worker that didn't work in JSC last time I checked that(LayoutTests/inspector-protocol/debugger-pause-dedicated-worker.html). This may have changed after your recent changes to WorkerScriptDebugServer.
> 
> Ok, I'll check it and report the newest situation here. Thank you.

My local Qt build (r135111) can pass this case.
Comment 5 Brent Fulgham 2014-10-17 13:49:51 PDT
This test appears to be working. Please reopen if you find that there is still an issue with this test.
Comment 6 Alexey Proskuryakov 2014-11-20 14:14:19 PST
The test is skipped on Mac, which is why the flakiness dashboard doesn't see it fail.
Comment 7 Radar WebKit Bug Importer 2014-11-20 14:14:33 PST
<rdar://problem/19049362>
Comment 8 Joseph Pecoraro 2016-11-17 14:37:16 PST

*** This bug has been marked as a duplicate of bug 164136 ***