RESOLVED DUPLICATE of bug 164136 100846
[JSC] Web Inspector: support Debugger.pause for dedicated workers 
https://bugs.webkit.org/show_bug.cgi?id=100846
Summary [JSC] Web Inspector: support Debugger.pause for dedicated workers
Yury Semikhatsky
Reported 2012-10-31 06:14:36 PDT
Pause command should worker for dedicated workers in JSC.
Attachments
Add attachment proposed patch, testcase, etc.
Peter Wang
Comment 1 2012-11-19 00:49:59 PST
So far, the Pause commands are same for shared and dedicated worker of JSC, it just set a flag to let JSC engine to stop on next statement. Are there some special cases have to be considered? Please give some tips, thank you very much.
Yury Semikhatsky
Comment 2 2012-11-19 01:07:28 PST
(In reply to comment #1) > So far, the Pause commands are same for shared and dedicated worker of JSC, it just set a flag to let JSC engine to stop on next statement. > > Are there some special cases have to be considered? Please give some tips, thank you very much. The pause command should work even if the worker is in a tight loop so that we can pause long-running scripts. Apart from that there is nothing special about the pause for workers. There is a sanity test for pause in dedicated worker that didn't work in JSC last time I checked that(LayoutTests/inspector-protocol/debugger-pause-dedicated-worker.html). This may have changed after your recent changes to WorkerScriptDebugServer.
Peter Wang
Comment 3 2012-11-19 01:11:13 PST
(In reply to comment #2) > (In reply to comment #1) > > So far, the Pause commands are same for shared and dedicated worker of JSC, it just set a flag to let JSC engine to stop on next statement. > > > > Are there some special cases have to be considered? Please give some tips, thank you very much. > > The pause command should work even if the worker is in a tight loop so that we can pause long-running scripts. Apart from that there is nothing special about the pause for workers. > > There is a sanity test for pause in dedicated worker that didn't work in JSC last time I checked that(LayoutTests/inspector-protocol/debugger-pause-dedicated-worker.html). This may have changed after your recent changes to WorkerScriptDebugServer. Ok, I'll check it and report the newest situation here. Thank you.
Peter Wang
Comment 4 2012-11-19 02:02:10 PST
(In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > > So far, the Pause commands are same for shared and dedicated worker of JSC, it just set a flag to let JSC engine to stop on next statement. > > > > > > Are there some special cases have to be considered? Please give some tips, thank you very much. > > > > The pause command should work even if the worker is in a tight loop so that we can pause long-running scripts. Apart from that there is nothing special about the pause for workers. > > > > There is a sanity test for pause in dedicated worker that didn't work in JSC last time I checked that(LayoutTests/inspector-protocol/debugger-pause-dedicated-worker.html). This may have changed after your recent changes to WorkerScriptDebugServer. > > Ok, I'll check it and report the newest situation here. Thank you. My local Qt build (r135111) can pass this case.
Brent Fulgham
Comment 5 2014-10-17 13:49:51 PDT
This test appears to be working. Please reopen if you find that there is still an issue with this test.
Alexey Proskuryakov
Comment 6 2014-11-20 14:14:19 PST
The test is skipped on Mac, which is why the flakiness dashboard doesn't see it fail.
Radar WebKit Bug Importer
Comment 7 2014-11-20 14:14:33 PST
<rdar://problem/19049362>
Joseph Pecoraro
Comment 8 2016-11-17 14:37:16 PST
*** This bug has been marked as a duplicate of bug 164136 ***
Note You need to log in before you can comment on or make changes to this bug.