Bug 100836 - [WK2/EFL] Make sure all our events are transformed correctly
Summary: [WK2/EFL] Make sure all our events are transformed correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Rohde Christiansen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-31 02:54 PDT by Kenneth Rohde Christiansen
Modified: 2012-10-31 04:41 PDT (History)
5 users (show)

See Also:


Attachments
Patch (22.60 KB, patch)
2012-10-31 03:34 PDT, Kenneth Rohde Christiansen
menard: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Rohde Christiansen 2012-10-31 02:54:21 PDT
SSIA
Comment 1 Kenneth Rohde Christiansen 2012-10-31 03:34:09 PDT
Created attachment 171611 [details]
Patch
Comment 2 Mikhail Pozdnyakov 2012-10-31 04:01:49 PDT
Comment on attachment 171611 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171611&action=review

looks nice

> Source/WebKit2/Shared/NativeWebTouchEvent.h:46
> +    NativeWebTouchEvent(Ewk_Touch_Event_Type, const Eina_List*, const Evas_Modifier*, const WebCore::AffineTransform&, const WebCore::AffineTransform&, double timestamp);

would clarify what each AffineTransform mean
Comment 3 Kenneth Rohde Christiansen 2012-10-31 04:08:04 PDT
> would clarify what each AffineTransform mean

can be done before landing, sure.
Comment 4 Kenneth Rohde Christiansen 2012-10-31 04:41:37 PDT
Landed in r133012