Bug 100824 – Memory instrumentation: do not report memory occupied by objects referenced using client interfaces

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Yury Semikhatsky]

In many classes we have pointer to a client object. These references should be reported as weak pointers and the client's memory usage should be reported when the client is reached from its instrumented owner where we know exact type of the client. Otherwise we would need to add reportMemoryUsage to all client interfaces which place additional burden on the client implementers and blur the instrumentation boundaries.

[Yury Semikhatsky]

Created attachment 171592 [details]
Patch

[Yury Semikhatsky]

(In reply to comment #1)
> Created an attachment (id=171592) [details]
> Patch

After these change number of objects counted by the memory instrumentation that haven't been allocated on the heap using malloc drops to 0 on nytimes.com in Chromium.

[Alexander Pavlov (apavlov)]

Comment on attachment 171592 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171592&action=review

> Source/WebCore/ChangeLog:12
> +        interfaces which place additional burden on the client implementers and blur

place -> places, blur -> blurs

[Yury Semikhatsky]

(In reply to comment #3)
> (From update of attachment 171592 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=171592&action=review
> 
> > Source/WebCore/ChangeLog:12
> > +        interfaces which place additional burden on the client implementers and blur
> 
> place -> places, blur -> blurs

Done.

[Yury Semikhatsky]

Committed r132998: <http://trac.webkit.org/changeset/132998>