WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
100824
Memory instrumentation: do not report memory occupied by objects referenced using client interfaces
https://bugs.webkit.org/show_bug.cgi?id=100824
Summary
Memory instrumentation: do not report memory occupied by objects referenced u...
Yury Semikhatsky
Reported
2012-10-31 00:40:42 PDT
In many classes we have pointer to a client object. These references should be reported as weak pointers and the client's memory usage should be reported when the client is reached from its instrumented owner where we know exact type of the client. Otherwise we would need to add reportMemoryUsage to all client interfaces which place additional burden on the client implementers and blur the instrumentation boundaries.
Attachments
Patch
(6.32 KB, patch)
2012-10-31 00:44 PDT
,
Yury Semikhatsky
apavlov
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1
2012-10-31 00:44:54 PDT
Created
attachment 171592
[details]
Patch
Yury Semikhatsky
Comment 2
2012-10-31 00:46:14 PDT
(In reply to
comment #1
)
> Created an attachment (id=171592) [details] > Patch
After these change number of objects counted by the memory instrumentation that haven't been allocated on the heap using malloc drops to 0 on nytimes.com in Chromium.
Alexander Pavlov (apavlov)
Comment 3
2012-10-31 01:28:25 PDT
Comment on
attachment 171592
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=171592&action=review
> Source/WebCore/ChangeLog:12 > + interfaces which place additional burden on the client implementers and blur
place -> places, blur -> blurs
Yury Semikhatsky
Comment 4
2012-10-31 01:35:42 PDT
(In reply to
comment #3
)
> (From update of
attachment 171592
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=171592&action=review
> > > Source/WebCore/ChangeLog:12 > > + interfaces which place additional burden on the client implementers and blur > > place -> places, blur -> blurs
Done.
Yury Semikhatsky
Comment 5
2012-10-31 01:36:34 PDT
Committed
r132998
: <
http://trac.webkit.org/changeset/132998
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug