Bug 100822 - [EFL][WK2] Add File Chooser dialog support to MiniBrowser
Summary: [EFL][WK2] Add File Chooser dialog support to MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 100818 100962
Blocks:
  Show dependency tree / graph
 
Reported: 2012-10-31 00:21 PDT by Chris Dumez
Modified: 2012-11-01 08:42 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.03 KB, patch)
2012-11-01 06:29 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-10-31 00:21:50 PDT 
MiniBrowser should show a file chooser dialog when the user click on an input element of type "file".
Comment 1 Chris Dumez 2012-11-01 06:29:31 PDT 
Created attachment 171829 [details]
Patch
Comment 2 WebKit Review Bot 2012-11-01 07:18:05 PDT 
Comment on attachment 171829 [details]
Patch

Clearing flags on attachment: 171829

Committed r133163: <http://trac.webkit.org/changeset/133163>
Comment 3 WebKit Review Bot 2012-11-01 07:18:10 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Sudarsana Nagineni (babu) 2012-11-01 08:31:33 PDT 
Comment on attachment 171829 [details]
Patch

I am wondering what happens if we close the main window when the dialog is opened since it is not a modal dialog. My guess is that it can cause the MiniBrowser to crash.
Comment 5 Chris Dumez 2012-11-01 08:33:50 PDT 
(In reply to comment #4)
> (From update of attachment 171829 [details])
> I am wondering what happens if we close the main window when the dialog is opened since it is not a modal dialog. My guess is that it can cause the MiniBrowser to crash.

Good point babu. I have to admit I did not try that. I'll check now.