Bug 100800 - webkitpy: refactor common command line arguments for --platform, rebaseline commands
Summary: webkitpy: refactor common command line arguments for --platform, rebaseline c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-30 17:36 PDT by Dirk Pranke
Modified: 2012-10-31 11:32 PDT (History)
5 users (show)

See Also:


Attachments
Patch (14.98 KB, patch)
2012-10-30 17:37 PDT, Dirk Pranke
ojan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-10-30 17:36:05 PDT
webkitpy: refactor common command line arguments for --platform, rebaseline commands
Comment 1 Dirk Pranke 2012-10-30 17:37:07 PDT
Created attachment 171557 [details]
Patch
Comment 2 Ojan Vafai 2012-10-30 20:49:44 PDT
Comment on attachment 171557 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171557&action=review

> Tools/Scripts/webkitpy/tool/commands/rebaseline.py:63
> +    move_overwritten_baselines_option = optparse.make_option("--move-overwritten-baselines", action="store_true", default=False,

This is unused?

> Tools/Scripts/webkitpy/tool/commands/rebaseline.py:70
> +    platform_options = factory.platform_options()

This is unused?
Comment 3 Dirk Pranke 2012-10-30 21:20:47 PDT
Comment on attachment 171557 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171557&action=review

>> Tools/Scripts/webkitpy/tool/commands/rebaseline.py:70
>> +    platform_options = factory.platform_options()
> 
> This is unused?

Yeah, these are both used in the next patch (for garden-o-matic and its called commands). I'll delete them for now.
Comment 4 Ojan Vafai 2012-10-30 21:49:59 PDT
Comment on attachment 171557 [details]
Patch

r=me with the unused bits deleted
Comment 5 Dirk Pranke 2012-10-31 11:32:31 PDT
Committed r133051: <http://trac.webkit.org/changeset/133051>