Bug 100798 - [Mac] Make WebKit2 Build with NETWORK_PROCESS disabled
Summary: [Mac] Make WebKit2 Build with NETWORK_PROCESS disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-30 17:22 PDT by Joseph Pecoraro
Modified: 2012-10-31 14:26 PDT (History)
3 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (8.04 KB, patch)
2012-10-30 17:29 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2012-10-30 17:22:05 PDT 
When I try to disabled ENABLE_NETWORK_PROCESS in WebKit2Prefix.h I get a ton of build errors.
Comment 1 Joseph Pecoraro 2012-10-30 17:29:09 PDT 
Created attachment 171555 [details]
[PATCH] Proposed Fix

Attached a proposed fix. Wrap more NetworkProcess related files and accessors in guards.
Comment 2 David Kilzer (:ddkilzer) 2012-10-30 17:46:44 PDT 
Comment on attachment 171555 [details]
[PATCH] Proposed Fix

r=me
Comment 3 WebKit Review Bot 2012-10-30 19:01:20 PDT 
Comment on attachment 171555 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 171555

Committed r132974: <http://trac.webkit.org/changeset/132974>
Comment 4 WebKit Review Bot 2012-10-30 19:01:24 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Brady Eidson 2012-10-31 01:15:12 PDT 
(In reply to comment #0)
> When I try to disabled ENABLE_NETWORK_PROCESS in WebKit2Prefix.h I get a ton of build errors.

There was a simple explanation for this, btw - We have no interest in continuing to build on Mac without the NetworkProcess enabled.  The guards in place were for other platforms that haven't started adopting NetworkProcess yet.

Can you explain to me (perhaps in email or IRC) why you think doing so is important?
Comment 6 Joseph Pecoraro 2012-10-31 14:26:29 PDT 
(In reply to comment #5)
> Can you explain to me (perhaps in email or IRC) why you think doing so is important?

I will follow up with you via email.