Bug 100765 - [CSS Exclusions] remove null exclusion shape check from ExclusionShape::createExclusionShape
Summary: [CSS Exclusions] remove null exclusion shape check from ExclusionShape::creat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Muller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-30 09:23 PDT by Bem Jones-Bey
Modified: 2012-11-19 08:55 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.64 KB, patch)
2012-11-15 16:44 PST, Hans Muller 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (1.63 KB, patch)
2012-11-16 09:32 PST, Hans Muller 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bem Jones-Bey 2012-10-30 09:23:13 PDT 
It doesn't really make sense for createExclusionShape to return null. It would be more with WebKit style to ensure that it need gets passed a null shape and have it ASSERT that the shape is not null. See comments on bug 100398 for the genesis of this bug.
Comment 1 Hans Muller 2012-11-15 16:44:26 PST 
Created attachment 174557 [details]
Patch

ExclusionShape::createExclusionShape now ASSERTs that its basicShape argument isn't null, since the caller is expected to ensure as much.
Comment 2 WebKit Review Bot 2012-11-15 18:07:32 PST 
Comment on attachment 174557 [details]
Patch

Attachment 174557 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14848604

New failing tests:
platform/chromium/virtual/threaded/compositing/webgl/webgl-background-color.html
Comment 3 Hans Muller 2012-11-16 09:32:06 PST 
Created attachment 174708 [details]
Patch

The probability that my small change to createExclusionShape() impacted a WebGL test seems extremely small so I've sync'd with the latest repository and uploaded a new version of the same patch.
Comment 4 WebKit Review Bot 2012-11-19 08:55:32 PST 
Comment on attachment 174708 [details]
Patch

Clearing flags on attachment: 174708

Committed r135166: <http://trac.webkit.org/changeset/135166>
Comment 5 WebKit Review Bot 2012-11-19 08:55:36 PST 
All reviewed patches have been landed.  Closing bug.