Bug 100760 – [BlackBerry] Update BB10 form theme.

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Tiancheng Jiang]

Upadte checkbox, radio, textfield, button, dropdown and range slider to meet cascade ux spec.

[Tiancheng Jiang]

Created attachment 171454 [details]
webkit patch

Introduce slice function to update form theme.

[Rob Buis]

Comment on attachment 171454 [details]
webkit patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171454&action=review

Don't forget that you need a ChangeLog! If you do one mention PR and internal reviewer.

> Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:74
> +// Slider Aura, caculated from UX spec

Typo caculated.

> Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:77
> +// Dropdown arrow position, caculated from UX spec

Ditto.

> Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:478
> +        if (!disabled || !background || !inactive || !pressed || !active || !activeMark || !disableMark)

You probably want to log something if this failed.

> Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:486
> +    float centerY = (float(inactive->height()) - float(activeMark->height())) / 2 / float(inactive->height()) * tmpRect.height() + tmpRect.y();

the double '/' looks weird, please try to add more parentheses.

> Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:541
> +    float centerY = (float(inactive->height()) - float(activeMark->height())) / 2 / float(inactive->height()) * tmpRect.height() + tmpRect.y();

Ditto.

[Tiancheng Jiang]

Created attachment 171497 [details]
webkit patch

[Rob Buis]

Comment on attachment 171497 [details]
webkit patch

LGTM.

[WebKit Review Bot]

Comment on attachment 171497 [details]
webkit patch

Rejecting attachment 171497 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
succeeded at 514 (offset -14 lines).
Hunk #11 succeeded at 570 (offset -14 lines).
Hunk #12 succeeded at 618 (offset -14 lines).
Hunk #13 succeeded at 625 (offset -14 lines).
Hunk #14 succeeded at 716 (offset -14 lines).
patching file Source/WebCore/platform/blackberry/RenderThemeBlackBerry.h
Hunk #1 succeeded at 105 (offset -5 lines).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14620947

[Tiancheng Jiang]

Created attachment 171540 [details]
Patch

[Rob Buis]

Comment on attachment 171540 [details]
Patch

LGTM.

[WebKit Review Bot]

Comment on attachment 171540 [details]
Patch

Clearing flags on attachment: 171540

Committed r132967: <http://trac.webkit.org/changeset/132967>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Tiancheng Jiang]

Reopening to attach new patch.

[Tiancheng Jiang]

Created attachment 171858 [details]
Patch

[Rob Buis]

Comment on attachment 171858 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171858&action=review

> Source/WebCore/ChangeLog:3
> +        Check img pointer is null, if so, do early return.

Bug title should go here.

> Source/WebCore/ChangeLog:9
> +

Fix description should go here.

[Tiancheng Jiang]

Created attachment 171861 [details]
Patch

[Tiancheng Jiang]

Created attachment 171872 [details]
Patch

[Rob Buis]

Comment on attachment 171872 [details]
Patch

LGTM.

[WebKit Review Bot]

Comment on attachment 171872 [details]
Patch

Clearing flags on attachment: 171872

Committed r133186: <http://trac.webkit.org/changeset/133186>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Tiancheng Jiang]

Reopening to attach new patch.

[Tiancheng Jiang]

Created attachment 172589 [details]
Patch

[Tiancheng Jiang]

Created attachment 172591 [details]
Patch

[Rob Buis]

Comment on attachment 172591 [details]
Patch

Ok.

[WebKit Review Bot]

Comment on attachment 172591 [details]
Patch

Clearing flags on attachment: 172591

Committed r133632: <http://trac.webkit.org/changeset/133632>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Tiancheng Jiang]

Reopening to attach new patch.

[Tiancheng Jiang]

Created attachment 172640 [details]
Patch

[Rob Buis]

Comment on attachment 172640 [details]
Patch

Ok.

[WebKit Review Bot]

Comment on attachment 172640 [details]
Patch

Clearing flags on attachment: 172640

Committed r133674: <http://trac.webkit.org/changeset/133674>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Tiancheng Jiang]

Reopening to attach new patch.

[Tiancheng Jiang]

Created attachment 172865 [details]
Patch

[Rob Buis]

Comment on attachment 172865 [details]
Patch

LGTM.

[WebKit Review Bot]

Comment on attachment 172865 [details]
Patch

Clearing flags on attachment: 172865

Committed r133808: <http://trac.webkit.org/changeset/133808>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Tiancheng Jiang]

Reopening to attach new patch.

[Tiancheng Jiang]

Created attachment 173511 [details]
Patch

[Tiancheng Jiang]

Created attachment 173513 [details]
Patch

[Rob Buis]

Comment on attachment 173513 [details]
Patch

The ChangeLog looks a bit strange but will hopefully work...

[WebKit Review Bot]

Comment on attachment 173513 [details]
Patch

Rejecting attachment 173513 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ILED at 739.
Hunk #5 succeeded at 973 (offset -14 lines).
Hunk #6 succeeded at 1007 (offset -14 lines).
Hunk #7 succeeded at 1031 (offset -14 lines).
2 out of 7 hunks FAILED -- saving rejects to file Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp.rej
patching file Source/WebCore/platform/blackberry/RenderThemeBlackBerry.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Rob Buis']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14689539

[Rob Buis]

Comment on attachment 173511 [details]
Patch

LGTM.

[WebKit Review Bot]

Comment on attachment 173511 [details]
Patch

Clearing flags on attachment: 173511

Committed r134227: <http://trac.webkit.org/changeset/134227>

[WebKit Review Bot]

Comment on attachment 173513 [details]
Patch

Clearing flags on attachment: 173513

Committed r134240: <http://trac.webkit.org/changeset/134240>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Tiancheng Jiang]

Reopening to attach new patch.

[Tiancheng Jiang]

Created attachment 173708 [details]
Patch

[Rob Buis]

Comment on attachment 173708 [details]
Patch

Ok.

[WebKit Review Bot]

Comment on attachment 173708 [details]
Patch

Clearing flags on attachment: 173708

Committed r134338: <http://trac.webkit.org/changeset/134338>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Tiancheng Jiang]

Reopening to attach new patch.

[Tiancheng Jiang]

Created attachment 174305 [details]
Patch

[Rob Buis]

Comment on attachment 174305 [details]
Patch

Ok.

[WebKit Review Bot]

Comment on attachment 174305 [details]
Patch

Clearing flags on attachment: 174305

Committed r134724: <http://trac.webkit.org/changeset/134724>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Tiancheng Jiang]

Reopening to attach new patch.

[Tiancheng Jiang]

Created attachment 176538 [details]
Patch

[Tiancheng Jiang]

Created attachment 176738 [details]
Patch

[Rob Buis]

Comment on attachment 176738 [details]
Patch

LGTM.

[WebKit Review Bot]

Comment on attachment 176738 [details]
Patch

Clearing flags on attachment: 176738

Committed r136136: <http://trac.webkit.org/changeset/136136>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Jeff Rogers]

*** Bug 101924 has been marked as a duplicate of this bug. ***

[Rob Buis]

Comment on attachment 176738 [details]
Patch

Ok.

[Tiancheng Jiang]

Reopening to attach new patch.

[Tiancheng Jiang]

Created attachment 202858 [details]
Patch

[Rob Buis]

Comment on attachment 202858 [details]
Patch

Ok.

[WebKit Commit Bot]

Comment on attachment 202858 [details]
Patch

Clearing flags on attachment: 202858

Committed r150754: <http://trac.webkit.org/changeset/150754>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Tiancheng Jiang]

Reopening to attach new patch.

[Tiancheng Jiang]

Created attachment 203083 [details]
Patch

[Rob Buis]

Comment on attachment 203083 [details]
Patch

LGTM.

[WebKit Commit Bot]

Comment on attachment 203083 [details]
Patch

Clearing flags on attachment: 203083

Committed r150908: <http://trac.webkit.org/changeset/150908>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.