Bug 100755 - [EFL] Baseline search path should consider both WK1 and WK2 on layout test.
Summary: [EFL] Baseline search path should consider both WK1 and WK2 on layout test.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kangil Han
URL:
Keywords:
Depends on:
Blocks: 100810
  Show dependency tree / graph
 
Reported: 2012-10-30 06:48 PDT by Kangil Han
Modified: 2012-10-30 21:32 PDT (History)
10 users (show)

See Also:

Attachments
patch (1.48 KB, patch)
2012-10-30 06:50 PDT, Kangil Han 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kangil Han 2012-10-30 06:48:47 PDT 
Currently, WK1 is not considered on layout test in baseline search path.
Comment 1 Kangil Han 2012-10-30 06:50:51 PDT 
Created attachment 171439 [details]
patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2012-10-30 07:25:10 PDT 
Comment on attachment 171439 [details]
patch

Looks OK.
Comment 3 WebKit Review Bot 2012-10-30 08:40:20 PDT 
Comment on attachment 171439 [details]
patch

Clearing flags on attachment: 171439

Committed r132910: <http://trac.webkit.org/changeset/132910>
Comment 4 WebKit Review Bot 2012-10-30 08:40:24 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Csaba Osztrogonác 2012-10-30 10:44:48 PDT 
It broke a python unit test:

    File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py", line 55, in test_baseline_directory
      self.assertEqual(command._baseline_directory("EFL Linux 64-bit Debug"), "/mock-checkout/LayoutTests/platform/efl")
  AssertionError: '/mock-checkout/LayoutTests/platform/efl-wk1' != '/mock-checkout/LayoutTests/platform/efl'

Could you update the test?
Comment 6 Kangil Han 2012-10-30 20:59:39 PDT 
(In reply to comment #5)
> It broke a python unit test:
> 
>     File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py", line 55, in test_baseline_directory
>       self.assertEqual(command._baseline_directory("EFL Linux 64-bit Debug"), "/mock-checkout/LayoutTests/platform/efl")
>   AssertionError: '/mock-checkout/LayoutTests/platform/efl-wk1' != '/mock-checkout/LayoutTests/platform/efl'
> 
> Could you update the test?

Oops.. I will figure out what has happened.