Bug 100746 - [EFL] combine color profile failures to the correct bug
Summary: [EFL] combine color profile failures to the correct bug
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jussi Kukkonen (jku)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-30 04:44 PDT by Jussi Kukkonen (jku)
Modified: 2012-10-30 07:14 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.47 KB, patch)
2012-10-30 04:50 PDT, Jussi Kukkonen (jku) 		no flags Details | Formatted Diff | Diff
I guess it would make sense. Changed to 'Color profiles are not currently used. See USE(QCMSLIB)'. (2.47 KB, patch)
2012-10-30 06:43 PDT, Jussi Kukkonen (jku) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jussi Kukkonen (jku) 2012-10-30 04:44:56 PDT 
TestExpectations gardening, patch coming.
Comment 1 Jussi Kukkonen (jku) 2012-10-30 04:50:05 PDT 
Created attachment 171421 [details]
Patch
Comment 2 Jussi Kukkonen (jku) 2012-10-30 05:00:06 PDT 
Comment on attachment 171421 [details]
Patch

forgot to add "cq?"
Comment 3 Raphael Kubo da Costa (:rakuco) 2012-10-30 06:08:54 PDT 
Comment on attachment 171421 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171421&action=review

> LayoutTests/platform/efl/TestExpectations:659
> +# EFL does not USE(QCMSLIB) so color transforms are not done

Wouldn't it make sense to make this comment more generic? I understood that this is something we're not really interested in fixing and not that it doesn't work because we do not use that lib.
Comment 4 Jussi Kukkonen (jku) 2012-10-30 06:43:54 PDT 
Created attachment 171436 [details]
I guess it would make sense. Changed to 'Color profiles are not currently used. See USE(QCMSLIB)'.
Comment 5 WebKit Review Bot 2012-10-30 07:14:19 PDT 
Comment on attachment 171436 [details]
I guess it would make sense. Changed to 'Color profiles are not currently used. See USE(QCMSLIB)'.

Clearing flags on attachment: 171436

Committed r132908: <http://trac.webkit.org/changeset/132908>
Comment 6 WebKit Review Bot 2012-10-30 07:14:23 PDT 
All reviewed patches have been landed.  Closing bug.