Bug 100744 - [BlackBerry] PurgeCredential should also purge the persisted credential store
Summary: [BlackBerry] PurgeCredential should also purge the persisted credential store
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Charles Wei
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-30 03:59 PDT by Charles Wei
Modified: 2012-10-30 19:02 PDT (History)
8 users (show)

See Also:


Attachments
Patch (1.95 KB, patch)
2012-10-30 04:06 PDT, Charles Wei
no flags Details | Formatted Diff | Diff
Patch (1.92 KB, patch)
2012-10-30 18:40 PDT, Charles Wei
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Wei 2012-10-30 03:59:13 PDT
NetworkJob::purgeCredentials() purges the credential from the memory that fails the authentication, which means that the credential is incorrect (it could be that it is incorrect from the beginning, or that it was correct but the credential was changed on server, could be through another device, etc.) and should not be used again.

We should also purge the credential record in the persistent credential storage (the CredentialBackingStore). Otherwise, the browser will read from the persistent credential storage and send the invalid credential again when challenged.
Comment 1 Charles Wei 2012-10-30 04:06:21 PDT
Created attachment 171415 [details]
Patch
Comment 2 Charles Wei 2012-10-30 04:13:34 PDT
Internal tracking No: 233482
Comment 3 WebKit Review Bot 2012-10-30 05:14:34 PDT
Comment on attachment 171415 [details]
Patch

Rejecting attachment 171415 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
queue/Source/WebKit/chromium/third_party/skia/include --revision 6161 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
46>At revision 6161.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/14629506
Comment 4 Charles Wei 2012-10-30 18:40:18 PDT
Created attachment 171562 [details]
Patch
Comment 5 Charles Wei 2012-10-30 18:41:00 PDT
Comment on attachment 171562 [details]
Patch

Reviewed by George. Commit it.
Comment 6 WebKit Review Bot 2012-10-30 19:02:22 PDT
Comment on attachment 171562 [details]
Patch

Clearing flags on attachment: 171562

Committed r132976: <http://trac.webkit.org/changeset/132976>
Comment 7 WebKit Review Bot 2012-10-30 19:02:28 PDT
All reviewed patches have been landed.  Closing bug.