RESOLVED FIXED 100742
[subixel] Change LineWidth::shrinkAvailableWidthForNewFloatIfNeeded to not pixel snap 
https://bugs.webkit.org/show_bug.cgi?id=100742
Summary [subixel] Change LineWidth::shrinkAvailableWidthForNewFloatIfNeeded to not pi...
Emil A Eklund
Reported 2012-10-30 03:55:32 PDT
As we no longer pixel snap values when computing the current width for a line we shouldn't do it in shrinkAvailableWidthForNewFloatIfNeeded either.
Attachments
Patch (5.58 KB, patch)
2012-10-30 04:06 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch (5.46 KB, patch)
2012-10-30 04:17 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2012-10-30 04:06:20 PDT
Created attachment 171414 [details] Patch
Emil A Eklund
Comment 2 2012-10-30 04:07:52 PDT
Downstream chromium bug: http://code.google.com/p/chromium/issues/detail?id=156971
Eric Seidel (no email)
Comment 3 2012-10-30 04:15:28 PDT
Comment on attachment 171414 [details] Patch OK.
Emil A Eklund
Comment 4 2012-10-30 04:17:31 PDT
Created attachment 171416 [details] Patch
Levi Weintraub
Comment 5 2012-10-30 04:23:17 PDT
Comment on attachment 171416 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171416&action=review > Source/WebCore/rendering/RenderBlockLineLayout.cpp:-103 > -#else > - bool fitsOnLine() const { return currentWidth() <= m_availableWidth; } > - bool fitsOnLine(float extra) const { return currentWidth() + extra <= m_availableWidth; } > -#endif Good catch. > Source/WebCore/rendering/RenderBlockLineLayout.cpp:175 > - float newLeft = m_block->pixelSnappedLogicalRightForFloat(newFloat); > + float newLeft = m_block->logicalRightForFloat(newFloat); Good to see more of these pixel snappings becoming unnecessary.
Levi Weintraub
Comment 6 2012-10-30 04:29:16 PDT
(In reply to comment #3) > (From update of attachment 171414 [details]) > OK. Eseidel doesn't sleep, he waits.
WebKit Review Bot
Comment 7 2012-10-30 06:36:51 PDT
Comment on attachment 171416 [details] Patch Clearing flags on attachment: 171416 Committed r132904: <http://trac.webkit.org/changeset/132904>
WebKit Review Bot
Comment 8 2012-10-30 06:36:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.