Bug 100741 – [AC] Fix compilation warnings when enabling Accelerated Compositing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Chris Dumez]

We get the following compilation warnings on EFL port when enabling Accelerated Compositing:
/home/chris/Devel/WebKit/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp: In member function 'virtual void WebCore::BitmapTextureGL::updateContents(const void*, const WebCore::IntRect&, const WebCore::IntPoint&, int, WebCore::BitmapTexture::UpdateContentsFlag)':
/home/chris/Devel/WebKit/Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:669:46: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

/home/chris/Devel/WebKit/Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:122:5: warning: unused parameter ‘shareContext’ [-Wunused-parameter]
/home/chris/Devel/WebKit/Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:322:13: warning: unused parameter ‘p’ [-Wunused-parameter]
/home/chris/Devel/WebKit/Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:360:6: warning: unused parameter ‘target’ [-Wunused-parameter]
/home/chris/Devel/WebKit/Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:360:6: warning: unused parameter ‘id’ [-Wunused-parameter]
/home/chris/Devel/WebKit/Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:360:6: warning: unused parameter ‘targetRect’ [-Wunused-parameter]
/home/chris/Devel/WebKit/Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:360:6: warning: unused parameter ‘offset’ [-Wunused-parameter]
/home/chris/Devel/WebKit/Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:430:7: warning: unused parameter ‘rect’ [-Wunused-parameter]
/home/chris/Devel/WebKit/Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:430:7: warning: unused parameter ‘outputStride’ [-Wunused-parameter]
/home/chris/Devel/WebKit/Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:430:7: warning: unused parameter ‘lockOptions’ [-Wunused-parameter]

[Chris Dumez]

Created attachment 171411 [details]
Patch

[Chris Dumez]

BTW, we should probably move Source/WebCore/platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp to another folder because it looks really weird for the EFL port to build files from a Qt folder.

[WebKit Review Bot]

Comment on attachment 171411 [details]
Patch

Rejecting attachment 171411 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 12787 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
50>At revision 12787.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/14627522

[Chris Dumez]

Created attachment 171444 [details]
Patch for landing

Rebased on master. Could someone please cq+?

[WebKit Review Bot]

Comment on attachment 171444 [details]
Patch for landing

Clearing flags on attachment: 171444

Committed r132911: <http://trac.webkit.org/changeset/132911>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.