Bug 100739 – [CSS] Expand -webkit-line-break value space

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Glenn Adams]

(1) expand -webkit-line-break to include new values defined by CSS3 Text [1], i.e., 'auto', 'strict', 'loose';
(2) change default (initial) value for -webkit-line-break to 'auto' to match CSS3 Text;
(3) rename enum EKHTMLLineBreak to LineBreak, renaming enum values appropriately;

this bug is a sub-division of bug 89235, and prepares the way for committing a patch thereto

[1] http://dev.w3.org/csswg/css3-text/#line-break

[Glenn Adams]

Created attachment 171418 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 171418 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171418&action=review

> Source/WebCore/rendering/style/StyleRareInheritedData.cpp:74
> -    , khtmlLineBreak(LBNORMAL)
> +    , lineBreak(LineBreakAuto)

Do we need to change the code which depends on this value?  Is our linebreaking still correct?

[Glenn Adams]

(In reply to comment #2)
> (From update of attachment 171418 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=171418&action=review
> 
> > Source/WebCore/rendering/style/StyleRareInheritedData.cpp:74
> > -    , khtmlLineBreak(LBNORMAL)
> > +    , lineBreak(LineBreakAuto)
> 
> Do we need to change the code which depends on this value?  Is our linebreaking still correct?

No change needed. There is actually no code that explicitly refers to LBNORMAL (now LineBreakAuto). I believe we're safe to c+ this.

[Eric Seidel (no email)]

Comment on attachment 171418 [details]
Patch

OK.  THanks.  I really appreciate you breaking this up, it makes it easier to handle the reviews.  Please feel encouraged to CC me on future patches.

[WebKit Review Bot]

Comment on attachment 171418 [details]
Patch

Clearing flags on attachment: 171418

Committed r132942: <http://trac.webkit.org/changeset/132942>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.