Bug 100724 - [BlackBerry] Clean the code of "JavaScriptDebuggerBlackBerry"
Summary: [BlackBerry] Clean the code of "JavaScriptDebuggerBlackBerry"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-29 20:39 PDT by Peter Wang
Modified: 2012-10-30 19:50 PDT (History)
10 users (show)

See Also:

Attachments
Patch (17.15 KB, patch)
2012-10-29 21:04 PDT, Peter Wang 		no flags Details | Formatted Diff | Diff
Patch (17.10 KB, patch)
2012-10-30 18:43 PDT, Peter Wang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Wang 2012-10-29 20:39:27 PDT 
Just open this bug to clean the code of "JavaScriptDebuggerBlackBerry".
Comment 1 Peter Wang 2012-10-29 21:04:24 PDT 
Created attachment 171367 [details]
Patch
Comment 2 Konrad Piascik 2012-10-30 06:48:11 PDT 
The patch looks fine to me, I'd just like a better commit message.  We're not cleaning up the code but removing it entirely.
Comment 3 Rob Buis 2012-10-30 06:53:22 PDT 
Comment on attachment 171367 [details]
Patch

Based on Konrad's comment, this patch seems okay but please fix the ChangeLog before landing, I guess that includes changing the bug title.
Comment 4 Peter Wang 2012-10-30 18:17:40 PDT 
(In reply to comment #3)
> (From update of attachment 171367 [details])
> Based on Konrad's comment, this patch seems okay but please fix the ChangeLog before landing, I guess that includes changing the bug title.

Ok, thank you very much
Comment 5 Peter Wang 2012-10-30 18:43:22 PDT 
Created attachment 171563 [details]
Patch
Comment 6 Peter Wang 2012-10-30 18:59:49 PDT 
Comment on attachment 171563 [details]
Patch

reviewed by Rob, new path is for correct ChangeLog
Comment 7 WebKit Review Bot 2012-10-30 19:00:15 PDT 
Comment on attachment 171563 [details]
Patch

Rejecting attachment 171563 [details] from review queue.

peter.wang@torchmobile.com.cn does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 8 Peter Wang 2012-10-30 19:00:57 PDT 
Comment on attachment 171563 [details]
Patch

reviewed by Rob, new path is for correct ChangeLog
Comment 9 WebKit Review Bot 2012-10-30 19:50:49 PDT 
Comment on attachment 171563 [details]
Patch

Clearing flags on attachment: 171563

Committed r132978: <http://trac.webkit.org/changeset/132978>
Comment 10 WebKit Review Bot 2012-10-30 19:50:54 PDT 
All reviewed patches have been landed.  Closing bug.