Bug 100704 - [CSS Exclusions] Clean up shape-inside tests' subpixel snapping code
Summary: [CSS Exclusions] Clean up shape-inside tests' subpixel snapping code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bear Travis
URL:
Keywords:
Depends on:
Blocks: 100307
  Show dependency treegraph
 
Reported: 2012-10-29 15:10 PDT by Bear Travis
Modified: 2012-11-02 18:22 PDT (History)
3 users (show)

See Also:


Attachments
initial patch (3.20 KB, patch)
2012-10-29 15:15 PDT, Bear Travis
no flags Details | Formatted Diff | Diff
Factoring out subpixel test code to separate file (13.63 KB, patch)
2012-10-30 13:24 PDT, Bear Travis
no flags Details | Formatted Diff | Diff
Adding polygon tests (25.96 KB, patch)
2012-10-30 14:13 PDT, Bear Travis
no flags Details | Formatted Diff | Diff
Updating patch (26.08 KB, patch)
2012-11-01 12:04 PDT, Bear Travis
no flags Details | Formatted Diff | Diff
refactoring subpixel rounding into the .js file (23.92 KB, patch)
2012-11-02 11:50 PDT, Bear Travis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bear Travis 2012-10-29 15:10:44 PDT
Layout pixel snaps the position of segments for shape-inside.
Modify the rounded rectangle tests to use the same pixel snapping as the polygon tests.

In sub-pixel layout, the result may be slightly different.
Comment 1 Bear Travis 2012-10-29 15:15:32 PDT
Created attachment 171321 [details]
initial patch
Comment 2 Bear Travis 2012-10-30 13:24:12 PDT
Created attachment 171511 [details]
Factoring out subpixel test code to separate file
Comment 3 Bear Travis 2012-10-30 13:54:09 PDT
Modifying bug to cover factoring subpixel code out of polygon tests as well.
Comment 4 Bear Travis 2012-10-30 14:13:24 PDT
Created attachment 171518 [details]
Adding polygon tests
Comment 5 WebKit Review Bot 2012-10-30 19:09:40 PDT
Comment on attachment 171518 [details]
Adding polygon tests

Attachment 171518 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14662059

New failing tests:
fast/exclusions/shape-inside/shape-inside-rounded-rectangle-003.html
Comment 6 Dirk Schulze 2012-10-31 05:59:07 PDT
Comment on attachment 171518 [details]
Adding polygon tests

Can you investigate why one of the exclusion tests is failing please? Does subPixelLayoutEnabled() not help here? Is it another problem and we need to skip it?
Comment 7 Bear Travis 2012-11-01 12:04:35 PDT
Created attachment 171905 [details]
Updating patch

Forgot to pass along the subpixel argument when generating tests.
Comment 8 Bear Travis 2012-11-02 11:50:30 PDT
Created attachment 172099 [details]
refactoring subpixel rounding into the .js file
Comment 9 Dirk Schulze 2012-11-02 17:54:28 PDT
Comment on attachment 172099 [details]
refactoring subpixel rounding into the .js file

LGTM. r=me.
Comment 10 WebKit Review Bot 2012-11-02 18:22:17 PDT
Comment on attachment 172099 [details]
refactoring subpixel rounding into the .js file

Clearing flags on attachment: 172099

Committed r133384: <http://trac.webkit.org/changeset/133384>
Comment 11 WebKit Review Bot 2012-11-02 18:22:21 PDT
All reviewed patches have been landed.  Closing bug.