Bug 100703 - Coordinated Graphics: support the "freeze animations" API
Summary: Coordinated Graphics: support the "freeze animations" API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Balazs Kelemen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-29 15:02 PDT by Noam Rosenthal
Modified: 2012-11-18 15:00 PST (History)
8 users (show)

See Also:

Attachments
Patch (7.80 KB, patch)
2012-11-15 06:55 PST, Balazs Kelemen 		no flags Details | Formatted Diff | Diff
Patch (1.50 KB, patch)
2012-11-16 08:06 PST, Balazs Kelemen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2012-10-29 15:02:40 PDT 
Right now we can't reliably test pixels of animations, because freeze is not implemented. We need to support freeze in coordinated graphics by sending a timestamp when CoordinatedGraphicsLayer::suspendAnimations is called and respect it in LayerTreeRenderer.
Comment 1 Rafael Brandao 2012-11-13 06:20:41 PST 
I'll drop this for now, but here's some bugs that might point to the right direction: 100673, 100769, 27627, 43792, 43733.
Comment 2 Balazs Kelemen 2012-11-14 01:30:28 PST 
I can go for it.
Comment 3 Balazs Kelemen 2012-11-15 06:55:53 PST 
Created attachment 174425 [details]
Patch
Comment 4 Balazs Kelemen 2012-11-15 07:27:51 PST 
Comment on attachment 174425 [details]
Patch

Clearing flags on attachment: 174425

Committed r134772: <http://trac.webkit.org/changeset/134772>
Comment 5 Balazs Kelemen 2012-11-15 07:27:55 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Dongseong Hwang 2012-11-16 03:21:33 PST 
After this patch, jank appears in most of all animations.

For example, falling leaves. http://www.webkit.org/blog-files/leaves/index.html
Comment 7 Balazs Kelemen 2012-11-16 03:52:31 PST 
(In reply to comment #6)
> After this patch, jank appears in most of all animations.
> 
> For example, falling leaves. http://www.webkit.org/blog-files/leaves/index.html

Tanks, I will look into this.
Comment 8 Balazs Kelemen 2012-11-16 08:03:37 PST 
Err, I was just missing to initialize the new members, and it did not cause problem in DRT and I did not check the browser.
Comment 9 Balazs Kelemen 2012-11-16 08:06:36 PST 
Created attachment 174685 [details]
Patch
Comment 10 Balazs Kelemen 2012-11-16 08:13:07 PST 
Comment on attachment 174685 [details]
Patch

Clearing flags on attachment: 174685

Committed r134952: <http://trac.webkit.org/changeset/134952>
Comment 11 Balazs Kelemen 2012-11-16 08:13:12 PST 
All reviewed patches have been landed.  Closing bug.
Comment 12 Dongseong Hwang 2012-11-18 15:00:05 PST 
Thanks for fixing it!