Bug 100695 – Web Inspector: Output code evaluated in the console the same as console.log

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Nikita Vasilyev]

console.log shows a nice summary of an object:

> obj = {x: 1}
> console.log(obj)
Object {x: 1}

Just typing a variable name in the console shows it the old uninformative way:

> obj
Object

I expect it to work the same as console.log

[Yury Semikhatsky]

Created attachment 171382 [details]
Patch

[WebKit Review Bot]

Attachment 171382 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/inspector/InjectedScript.cpp:64:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:75:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:86:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorRuntimeAgent.h:71:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/inspector/InspectorDebuggerAgent.h:110:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/inspector/InjectedScript.h:61:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/inspector/InjectedScript.h:79:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 7 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 171382 [details]
Patch

Attachment 171382 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14632417

New failing tests:
inspector/console/console-eval-global.html
inspector/debugger/event-listener-breakpoints.html
inspector/debugger/eval-on-pause-blocked.html
inspector/debugger/debugger-eval-while-paused.html
inspector/debugger/debugger-no-nested-pause.html
inspector/console/command-line-api-inspect.html
http/tests/inspector/network/network-initiator-from-console.html
inspector/console/console-api-on-call-frame.html
inspector/console/console-format.html
http/tests/inspector/console-cd-completions.html
inspector/debugger/debugger-eval-on-call-frame.html
inspector/console/command-line-api.html
inspector/console/console-eval-undefined-override.html
inspector/debugger/debugger-suspend-active-dom-objects.html

[Build Bot]

Comment on attachment 171382 [details]
Patch

Attachment 171382 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14625529

New failing tests:
inspector/console/console-eval-global.html
inspector/console/console-api-on-call-frame.html
inspector/debugger/eval-on-pause-blocked.html
inspector/debugger/debugger-no-nested-pause.html
inspector/console/command-line-api-inspect.html
inspector/debugger/disable-script.html
http/tests/inspector/network/network-initiator-from-console.html
inspector/debugger/debugger-eval-while-paused.html
inspector/console/console-format.html
inspector/debugger/function-details.html
inspector/console/console-eval-undefined-override.html
inspector/debugger/debugger-eval-on-call-frame.html
inspector/console/command-line-api.html
inspector/debugger/debugger-suspend-active-dom-objects.html

[Pavel Feldman]

Comment on attachment 171382 [details]
Patch

You probably want to rebaseline some tests.

[Yury Semikhatsky]

Created attachment 171666 [details]
Patch

[WebKit Review Bot]

Attachment 171666 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/inspector/console/command-line..." exit_code: 1
Source/WebCore/inspector/InjectedScript.cpp:64:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:75:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:86:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorRuntimeAgent.h:71:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/inspector/InjectedScript.h:61:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/inspector/InjectedScript.h:79:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/inspector/InspectorDebuggerAgent.h:110:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 7 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yury Semikhatsky]

Created attachment 171668 [details]
Patch

[Yury Semikhatsky]

(In reply to comment #5)
> (From update of attachment 171382 [details])
> You probably want to rebaseline some tests.

Indeed. Updated expectations to include object preview for evaluation results.

[WebKit Review Bot]

Attachment 171668 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/insp..." exit_code: 1
Source/WebCore/inspector/InjectedScript.cpp:64:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:75:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:86:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorRuntimeAgent.h:71:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/inspector/InjectedScript.h:61:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/inspector/InjectedScript.h:79:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/inspector/InspectorDebuggerAgent.h:110:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 7 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 171668 [details]
Patch

Attachment 171668 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14656247

New failing tests:
http/tests/inspector/network/network-initiator-from-console.html

[Yury Semikhatsky]

Created attachment 171792 [details]
Patch

[WebKit Review Bot]

Attachment 171792 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/http..." exit_code: 1
Source/WebCore/inspector/InjectedScript.cpp:64:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:75:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InjectedScript.cpp:86:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorRuntimeAgent.h:71:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/inspector/InjectedScript.h:61:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/inspector/InjectedScript.h:79:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/inspector/InspectorDebuggerAgent.h:110:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 7 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Pavel Feldman]

Comment on attachment 171792 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171792&action=review

> Source/WebCore/inspector/front-end/ConsoleMessage.js:358
> +    useArrayPreviewInFormatter: function(array)

Please annotate this method.

[Yury Semikhatsky]

(In reply to comment #14)
> (From update of attachment 171792 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=171792&action=review
> 
> > Source/WebCore/inspector/front-end/ConsoleMessage.js:358
> > +    useArrayPreviewInFormatter: function(array)
> 
> Please annotate this method.

Done.

[Yury Semikhatsky]

Committed r133150: <http://trac.webkit.org/changeset/133150>