Bug 100690 - Support captions when PLUGIN_PROXY_FOR_VIDEO
Summary: Support captions when PLUGIN_PROXY_FOR_VIDEO
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-29 11:06 PDT by Eric Carlson
Modified: 2012-10-29 13:02 PDT (History)
4 users (show)

See Also:


Attachments
Proposed patch (5.43 KB, patch)
2012-10-29 12:13 PDT, Eric Carlson
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2012-10-29 11:06:51 PDT
Support text tracks when PLUGIN_PROXY_FOR_VIDEO is defined.
Comment 1 Eric Carlson 2012-10-29 12:13:13 PDT
Created attachment 171289 [details]
Proposed patch
Comment 2 Simon Fraser (smfr) 2012-10-29 12:44:13 PDT
Comment on attachment 171289 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171289&action=review

> Source/WebCore/rendering/RenderEmbeddedObject.cpp:258
> +#if ENABLE(PLUGIN_PROXY_FOR_VIDEO)
> +    RenderBox* controlsRenderer = toRenderBox(m_children.firstChild());

I think it would be good to have a comment here pointing out that this code is duplicated from RenderVideo (or maybe even share code).
Comment 3 Eric Carlson 2012-10-29 13:02:14 PDT
http://trac.webkit.org/changeset/132842