Bug 100683 - Web Inspector: Style toolbar to match Chromium toolbar on Chromium/Mac.
Summary: Web Inspector: Style toolbar to match Chromium toolbar on Chromium/Mac.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: dubroy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-29 09:40 PDT by dubroy
Modified: 2012-10-29 10:52 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.05 KB, patch)
2012-10-29 09:42 PDT, dubroy 		no flags Details | Formatted Diff | Diff
Screenshot of old look (124.63 KB, image/png)
2012-10-29 09:43 PDT, dubroy 		no flags Details
Screenshot of new look. (114.34 KB, image/png)
2012-10-29 09:43 PDT, dubroy 		no flags Details
Fixed style. (2.05 KB, patch)
2012-10-29 09:49 PDT, dubroy 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dubroy 2012-10-29 09:40:37 PDT 
Web Inspector: Style toolbar to match Chromium toolbar on Chromium/Mac.
Comment 1 dubroy 2012-10-29 09:42:25 PDT 
Created attachment 171263 [details]
Patch
Comment 2 dubroy 2012-10-29 09:43:36 PDT 
Created attachment 171266 [details]
Screenshot of old look
Comment 3 dubroy 2012-10-29 09:43:54 PDT 
Created attachment 171267 [details]
Screenshot of new look.
Comment 4 WebKit Review Bot 2012-10-29 09:46:22 PDT 
Attachment 171263 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1
Source/WebKit/chromium/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 dubroy 2012-10-29 09:49:05 PDT 
Created attachment 171269 [details]
Fixed style.
Comment 6 Pavel Feldman 2012-10-29 09:53:31 PDT 
Comment on attachment 171269 [details]
Fixed style.

What about undocked mode? Also, note that when themed, we are passing the theme colors into the front-end. We could pass gradients instead and push this data from downstream at runtime.
Comment 7 WebKit Review Bot 2012-10-29 10:51:59 PDT 
Comment on attachment 171269 [details]
Fixed style.

Clearing flags on attachment: 171269

Committed r132821: <http://trac.webkit.org/changeset/132821>
Comment 8 WebKit Review Bot 2012-10-29 10:52:02 PDT 
All reviewed patches have been landed.  Closing bug.